Skip to content

[BUG] TypingIssue: CSV.writeBuffer() does support options #1165

@carmelid

Description

@carmelid

🐛 Bug Report

The typings for csv.writeBuffer does not comply with the implementation

Lib version: 3.8.1

Steps To Reproduce

import { CsvWriteOptions, Workbook } from 'exceljs';

const options: Partial<CsvWriteOptions> = { dateFormat: 'YYYY-MM-DD' };
const buff = new Workbook().csv.writeBuffer(options);

Line 4 generates a TS2554: Expected 0 arguments, but got 1. complie error.

The expected behaviour:

I expect this to compile just fine.

Possible solution (optional, but very helpful):

Update the typings to on line 1342 into

	/**
	 * write to a buffer
	 */
	writeBuffer(options?: Partial<CsvWriteOptions>): Promise<Buffer>;

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      pFad - Phonifier reborn

      Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

      Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


      Alternative Proxies:

      Alternative Proxy

      pFad Proxy

      pFad v3 Proxy

      pFad v4 Proxy