fix: internal function _addHook failure should be turned into the rejection that app.ready() is waiting for (#6105)

jean-michelet · web-flow · commit 8ddd4fa85629 · 2025-05-11T08:58:47.000+02:00
diff --git a/fastify.js b/fastify.js
@@ -681,8 +681,12 @@ function fastify (options) {
       this[kHooks].add(name, fn)
     } else {
       this.after((err, done) => {
-        _addHook.call(this, name, fn)
-        done(err)
+        try {
+          _addHook.call(this, name, fn)
+          done(err)
+        } catch (err) {
+          done(err)
+        }
       })
     }
     return this
diff --git a/test/internals/hooks.test.js b/test/internals/hooks.test.js
@@ -2,6 +2,7 @@
 
 const { test } = require('node:test')
 const { Hooks } = require('../../lib/hooks')
+const { default: fastify } = require('../../fastify')
 const noop = () => {}
 
 test('hooks should have 4 array with the registered hooks', t => {
@@ -77,3 +78,19 @@ test('should throw on wrong parameters', t => {
     t.assert.strictEqual(e.message, 'onSend hook should be a function, instead got [object Null]')
   }
 })
+
+test('Integration test: internal function _addHook should be turned into app.ready() rejection', async (t) => {
+  const app = fastify()
+
+  app.register(async function () {
+    app.addHook('notRealHook', async () => {})
+  })
+
+  try {
+    await app.ready()
+    t.assert.fail('Expected ready() to throw')
+  } catch (err) {
+    t.assert.strictEqual(err.code, 'FST_ERR_HOOK_NOT_SUPPORTED')
+    t.assert.match(err.message, /hook not supported/i)
+  }
+})
