Tweaks to adjust to new pygfx blending #838
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kushalkolar
reviewed
May 27, 2025
| @@ -560,6 +560,11 @@ def _render(self, draw=True): | |||
| # draw the underlay planes | |||
| self.renderer.render(self._underlay_scene, self._underlay_camera, flush=False) | |||
|
|
|||
| # With new pygfx' blending, the depth buffer is only cleared after each flush, we need a manual depth | |||
| # clear to erase the depth values set by the underlay. | |||
There was a problem hiding this comment.
Good point, you may want to use a different depth range in the camera, so that the fragments all have a very small depth value, so they don't get behind stuff in the scene. Or simply disable depth-tests.
There was a problem hiding this comment.
Or you can clear the depth buffer again, if you don't need it for post processing or things like that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For upcoming pygfx/pygfx#1002
May not be complete, can leave open until the pygfx-pr is merged.