Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix functions:secrets:set - stop erroring in non-interactive flows without force option #7467

Merged
merged 8 commits into from
Jul 30, 2024
Merged

Fix functions:secrets:set - stop erroring in non-interactive flows without force option #7467

merged 8 commits into from
Jul 30, 2024

Conversation

colerogers
Copy link
Contributor

@colerogers colerogers commented Jul 18, 2024 •
edited
Loading

Fixes #7466

@colerogers colerogers changed the title Adding error for non-interactive flows without force option Fix functions:secrets:set - add error for non-interactive flows without force option Jul 18, 2024
@colerogers colerogers requested review from taeold and aalej July 18, 2024 19:58
@ytetsuro
Copy link

@colerogers

Thank you.
If this PR is merge, it would be difficult to overwrite the secret manager value and terminate successfully without running redeploy.
Am I correct in my understanding?
I would rather not redeploy as I want to deploy stably.

@colerogers colerogers changed the title Fix functions:secrets:set - add error for non-interactive flows without force option Fix functions:secrets:set - stop erroring in the non-interactive flows without force option Jul 30, 2024
@colerogers colerogers changed the title Fix functions:secrets:set - stop erroring in the non-interactive flows without force option Fix functions:secrets:set - stop erroring in non-interactive flows without force option Jul 30, 2024
@colerogers colerogers enabled auto-merge (squash) July 30, 2024 19:14
@colerogers
Copy link
Contributor Author

@ytetsuro I think I understand the issue better, our behavior for running functions:secrets:set with responding no to the prompt was different than running functions:secrets:set --non-interactive. The latter was producing an error that the former was not. This PR should now fix that.

@colerogers colerogers merged commit 68be9c5 into master Jul 30, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joehan joehan joehan approved these changes

@taeold taeold Awaiting requested review from taeold

@aalej aalej Awaiting requested review from aalej

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@colerogers @ytetsuro @joehan
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy