Double zip FlutterMacOS.framework.zip. #41306
Conversation
This is required to make the artifact consistent with the legacy artifacts while the tool is modified to remove the need of double zipping. Bug: flutter/flutter#124911
There was a problem hiding this comment.
cross-linking with #35563 and flutter/flutter#110034
Fortunately the tool still handles unzipping the inner zip (which makes sense if it's still in v1)
Co-authored-by: Christopher Fujino <fujino@google.com>
| # Use doubled zipped file. | ||
| final_src_path = os.path.join(dst, 'FlutterMacOS.framework_.zip') | ||
| final_dst_path = os.path.join(dst, 'FlutterMacOS.framework.zip') | ||
| shutil.move(final_src_path, final_dst_path) |
There was a problem hiding this comment.
Should we delete FlutterMacOS.framework.zip first? Per https://docs.python.org/3/library/shutil.html#shutil.move,
If the destination already exists but is not a directory, it may be overwritten depending on os.rename() semantics.
I'm not sure what this means.
There was a problem hiding this comment.
Following that link (https://docs.python.org/3/library/os.html#os.rename): on Unix (which I'm assuming macOS is):
If both are files, dst will be replaced silently if the user has permission. The operation may fail on some Unix flavors if src and dst are on different filesystems.
So looks like this should work.
| # Use doubled zipped file. | ||
| final_src_path = os.path.join(dst, 'FlutterMacOS.framework_.zip') | ||
| final_dst_path = os.path.join(dst, 'FlutterMacOS.framework.zip') | ||
| shutil.move(final_src_path, final_dst_path) |
There was a problem hiding this comment.
Following that link (https://docs.python.org/3/library/os.html#os.rename): on Unix (which I'm assuming macOS is):
If both are files, dst will be replaced silently if the user has permission. The operation may fail on some Unix flavors if src and dst are on different filesystems.
So looks like this should work.
…125094) flutter/engine@099ed6c...8b7cdb0 2023-04-19 aam@google.com Roll dart, zlib, emscripten, tweak license script for rolled zlib (flutter/engine#41299) 2023-04-19 skia-flutter-autoroll@skia.org Roll Skia from 84630c3c18b2 to 5a718d9e9c06 (3 revisions) (flutter/engine#41318) 2023-04-19 bdero@google.com [Impeller] Provide an opaque interface for color sources in Aiks (flutter/engine#41315) 2023-04-18 yjbanov@google.com [web:canvaskit] remove unnecessary instrumentation from picture (flutter/engine#41313) 2023-04-18 skia-flutter-autoroll@skia.org Roll Skia from 476ee3fd54cc to 84630c3c18b2 (5 revisions) (flutter/engine#41316) 2023-04-18 godofredoc@google.com Double zip FlutterMacOS.framework.zip. (flutter/engine#41306) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This is required to make the artifact consistent with the legacy artifacts while the tool is modified to remove the need of double zipping.
Bug: flutter/flutter#124911
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.