comments

alex-medinsh · alex-medinsh · commit bbb1de35c2ff · 2025-06-27T00:25:16.000+03:00
diff --git a/engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterPlatformPlugin.mm b/engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterPlatformPlugin.mm
@@ -22,8 +22,10 @@
 namespace {
 
 constexpr char kTextPlainFormat[] = "text/plain";
+// Some of the official iOS system sounds. A full list can be found in many places online, such as:
+// https://github.com/p-x9/swift-system-sound/blob/cb4327b223d55d01e9156539c8442db16f4b1f85/SystemSoundTable.md
 const UInt32 kKeyPressClickSoundId = 1306;
-const UInt32 kPickerTickSoundId = 1157;
+const UInt32 kWheelsOfTimeSoundId = 1157;
 
 NSString* const kSearchURLPrefix = @"x-web-search://?";
 
@@ -245,7 +247,7 @@ - (void)playSystemSound:(NSString*)soundType {
     // iOS.
     AudioServicesPlaySystemSound(kKeyPressClickSoundId);
   } else if ([soundType isEqualToString:@"SystemSoundType.tick"]) {
-    AudioServicesPlaySystemSound(kPickerTickSoundId);
+    AudioServicesPlaySystemSound(kWheelsOfTimeSoundId);
   }
 }
 
diff --git a/engine/src/flutter/shell/platform/windows/platform_handler.cc b/engine/src/flutter/shell/platform/windows/platform_handler.cc
@@ -368,6 +368,12 @@ void PlatformHandler::SystemSoundPlay(
   if (sound_type.compare(kSoundTypeAlert) == 0) {
     MessageBeep(MB_OK);
     result->Success();
+  } else if (sound_type.compare(kSoundTypeClick) == 0) {
+    // No-op, as there is no system sound for key presses.
+    result->Success();
+  } else if (sound_type.compare(kSoundTypeTick) == 0) {
+    // No-op, as there is no system sound for ticks.
+    result->Success();
   } else {
     result->NotImplemented();
   }
diff --git a/engine/src/flutter/shell/platform/windows/platform_handler.h b/engine/src/flutter/shell/platform/windows/platform_handler.h
@@ -104,6 +104,8 @@ class PlatformHandler {
   static constexpr char kClipboardError[] = "Clipboard error";
 
   static constexpr char kSoundTypeAlert[] = "SystemSoundType.alert";
+  static constexpr char kSoundTypeClick[] = "SystemSoundType.click";
+  static constexpr char kSoundTypeTick[] = "SystemSoundType.tick";
 
  private:
   // Called when a method is called on |channel_|;
diff --git a/packages/flutter/lib/src/services/system_sound.dart b/packages/flutter/lib/src/services/system_sound.dart
@@ -24,8 +24,12 @@ enum SystemSoundType {
   /// ignored on the web as well.
   alert,
 
-  // If you add new values here, you also need to update the `SoundType` Java
-  // enum in `PlatformChannel.java`.
+  // If you add new values here, you also need to update:
+  // - the `SoundType` Java enum in `PlatformChannel.java` (Android);
+  // - `FlutterPlatformPlugin.mm` (iOS);
+  // - `FlutterPlatformPlugin.mm` (macOS);
+  // - `fl_platform_handler.cc` (Linux);
+  // - `platform_handler.cc` (Windows);
 }
 
 /// Provides access to the library of short system specific sounds for common
diff --git a/packages/flutter/test/cupertino/picker_test.dart b/packages/flutter/test/cupertino/picker_test.dart
@@ -398,7 +398,7 @@ void main() {
     });
 
     testWidgets(
-      'does not trigger haptics and sound when scrolling by tapping on the item',
+      'does not trigger haptics or sounds when scrolling by tapping on the item',
       (WidgetTester tester) async {
         final List<int> selectedItems = <int>[];
         final List<MethodCall> systemCalls = <MethodCall>[];
@@ -444,7 +444,7 @@ void main() {
     );
 
     testWidgets(
-      'do not trigger haptic and sound effects on non-iOS devices',
+      'do not trigger haptic or sounds on non-iOS devices',
       (WidgetTester tester) async {
         final List<int> selectedItems = <int>[];
         final List<MethodCall> systemCalls = <MethodCall>[];
