Skip to content

Consider building or analyzing plugins a second time with the latest iOS version #102835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
stuartmorgan-g opened this issue Apr 29, 2022 · 3 comments · Fixed by flutter/plugins#5778
Closed

Consider building or analyzing plugins a second time with the latest iOS version #102835

stuartmorgan-g opened this issue Apr 29, 2022 · 3 comments · Fixed by flutter/plugins#5778
Assignees
@stuartmorgan-g
Labels
c: contributor-productivity Team-specific productivity, code health, technical debt. p: tooling Affects the flutter_plugin_tools package P2 Important issues not at the top of the work list package flutter/packages repository. See also p: labels.

Comments

@stuartmorgan-g
Copy link
Contributor

We routinely get bugs, and sometimes PRs, about deprecation warnings in our plugins that only show up when building for a higher minimum version of iOS than we support. It would be nice if we caught that in CI so that we'd have enforcement of adding deprecation warning suppression pragmas as part of writing the code, instead of people filing bugs about it.

If it's not too time-intensive, we could have the plugin tooling know how to modify the example apps locally to the latest iOS version, and then we could run that step and then re-run build or analyze (whichever is cheaper) with warnings as errors, to catch use of anything that's deprecated but not pragma'd. (Or not necessarily the absolute latest; we could pick some new-but-not-too-new version to catch most cases, but not force us to immediately handle all deprecations, and then roll it forward once a year and add any new pragmas. Presumably not a lot of people are only supporting the absolute latest iOS.)

(This assumes that we are in fact treating warnings as errors in this scenario; see discussion in #91868)

/cc @jmagman
@stuartmorgan-g stuartmorgan-g added c: contributor-productivity Team-specific productivity, code health, technical debt. plugin p: tooling Affects the flutter_plugin_tools package P2 Important issues not at the top of the work list labels Apr 29, 2022
@jmagman
Copy link
Member

jmagman commented Apr 30, 2022 •
edited
Loading

If it's not too time-intensive, we could have the plugin tooling know how to modify the example apps locally to the latest iOS version

I think this would be as simple as passing IPHONEOS_DEPLOYMENT_TARGET=15.0 to xcodebuild similar to:
https://github.com/flutter/plugins/blob/d1105387872040cad7e09476b95332ffe0c531bf/script/tool/test/xcode_analyze_command_test.dart#L121

The version should matching the highest version iOS SDK supported by Xcode in the Cirrus mac VM image:
https://github.com/flutter/plugins/blob/a868c33370d305fb101b54a9e8f8ee769d5ef47a/.cirrus.yml#L61

So no need to modify the example project.

@stuartmorgan-g
Copy link
Contributor Author

I think this would be as simple as passing IPHONEOS_DEPLOYMENT_TARGET=15.0 to xcodebuild

It is indeed that easy :)

@stuartmorgan-g stuartmorgan-g self-assigned this May 16, 2022
@stuartmorgan-g stuartmorgan-g mentioned this issue May 17, 2022
Merged
11 tasks
@github-actions
Copy link

github-actions bot commented Jun 1, 2022

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 1, 2022
@flutter-triage-bot flutter-triage-bot bot added the package flutter/packages repository. See also p: labels. label Jul 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@stuartmorgan-g stuartmorgan-g

Labels
c: contributor-productivity Team-specific productivity, code health, technical debt. p: tooling Affects the flutter_plugin_tools package P2 Important issues not at the top of the work list package flutter/packages repository. See also p: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ci/tools] Add iOS/macOS analysis to catch deprecated code stuartmorgan-g/plugins
2 participants
@stuartmorgan-g @jmagman
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy