-
Notifications
You must be signed in to change notification settings - Fork 28.9k
Closed
Labels
P3Issues that are less important to the Flutter projectIssues that are less important to the Flutter projectc: new featureNothing broken; request for a new capabilityNothing broken; request for a new capabilityc: tech-debtTechnical debt, code quality, testing, etc.Technical debt, code quality, testing, etc.p: cameraThe camera pluginThe camera pluginpackageflutter/packages repository. See also p: labels.flutter/packages repository. See also p: labels.platform-androidAndroid applications specificallyAndroid applications specificallyteam-androidOwned by Android platform teamOwned by Android platform teamtriaged-androidTriaged by Android platform teamTriaged by Android platform team
Description
As the android_camera_camerax
plugin has been under development, there have a number of tasks that have not blocked PRs but are important technical debt to pay down. This umbrella issue covers those tasks that apply to refactoring wrapped native classes:
- Refactor logic in constructors/
create
methods to helper methods or to callers of those methods. - Remove any redundant documentation added or left by the autogenerator.
- [Dart-specific] Make Dart Host API implementations private.
- There are currently two ways to create files to save recordings to; condense to one.
- [Native-specific] Move checks for objects being managed by an
InstanceManager
to the Flutter API implementations themselves versus where instances of those implementations are used. - Use command pattern to use handlers to create objects of each type that is represented by a
LiveDataSupportedType
(see original comment).
Metadata
Metadata
Assignees
Labels
P3Issues that are less important to the Flutter projectIssues that are less important to the Flutter projectc: new featureNothing broken; request for a new capabilityNothing broken; request for a new capabilityc: tech-debtTechnical debt, code quality, testing, etc.Technical debt, code quality, testing, etc.p: cameraThe camera pluginThe camera pluginpackageflutter/packages repository. See also p: labels.flutter/packages repository. See also p: labels.platform-androidAndroid applications specificallyAndroid applications specificallyteam-androidOwned by Android platform teamOwned by Android platform teamtriaged-androidTriaged by Android platform teamTriaged by Android platform team