Skip to content

Ensure Flutter SDK stable releases ship with the same versions packages from the Dart SDK as Dart #138736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #130635
DanTup opened this issue Nov 20, 2023 · 2 comments
Labels
c: proposal A detailed proposal for a change to Flutter

Comments

@DanTup
Copy link
Contributor

DanTup commented Nov 20, 2023

I don't know what the solution to this is, but I think it's worth starting a discussion to see if there's a way to improve things.

Currently there are some packages inside the Dart SDK repository that ship both with Dart and are also published to pub and used by Flutter - for example DDS and DWDS.

Today, the version of these components inside the Dart SDK and the Flutter SDK can be different versions if changes are made in the Dart SDK, but they are not released to pub and rolled into Flutter. For example the recent DAP bug (dart-lang/sdk#54087) is an issue in the latest Flutter SDK but only for Flutter projects (which use flutter debug_adapter) and not for Dart projects (which use dart debug_adapter) from the same SDK version.

To avoid this, we need to ensure when a release is being made that any local packages in the SDK have been published to Pub and rolled into Flutter. Doing this manually is error prone - especially as Pub releases aren't pushed on every change (because that would be a big overhead).

One possible improvement would be to have a script that checks (when preparing a Flutter release) that the version in the pubspec.yaml for a package that lives in the Dart SDK repository matches the one in Flutter's pubspec.yaml (we could also check against Pub, but if Dart+Flutter match it's certain the package was published to Pub).

This would rely on the version being bumped in pubspec.yaml in the package in the SDK with changes, but I suspect that's something much less likely to be wrong than forgetting to do a Pub release prior to a branch.

@devoncarew @jacob314

@huycozy huycozy added in triage Presently being triaged by the triage team c: proposal A detailed proposal for a change to Flutter team-release and removed in triage Presently being triaged by the triage team labels Nov 21, 2023
@XilaiZhang XilaiZhang added team-tool Owned by Flutter Tool team fyi-release and removed team-release labels Dec 13, 2023
@bkonyi bkonyi added team-release and removed fyi-release team-tool Owned by Flutter Tool team labels Mar 31, 2025
@bkonyi
Copy link
Contributor

bkonyi commented Mar 31, 2025

This isn't a tool issue and probably needs to be handled by the release or infra teams.

@matanlurey
Copy link
Contributor

Closing as stale. Please feel free to open a new issue with a strong justification for doing this.

(To be clear, the -release and -infra teams have no plans to work on this in the known future)

@matanlurey matanlurey closed this as not planned Won't fix, can't repro, duplicate, stale May 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: proposal A detailed proposal for a change to Flutter
Projects
None yet
Development

No branches or pull requests

5 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy