Skip to content

engine_v2 tests are incorrectly run on dart-internal bots when they should run on prod #142626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
CaseyHillers opened this issue Jan 31, 2024 · 6 comments
Closed

engine_v2 tests are incorrectly run on dart-internal bots when they should run on prod #142626

CaseyHillers opened this issue Jan 31, 2024 · 6 comments
Labels
P2 Important issues not at the top of the work list

Comments

@CaseyHillers
Copy link
Contributor

Type of Request

bug

Infrastructure Environment

LUCI - engine_v2 recipe

What is happening?

https://ci.chromium.org/ui/p/dart-internal/builders/flutter/Linux%20engine_release_builder/815/overview failed due to linux_fuchsia not having any kvm bots in dart-internal to run on. The expectation is that tests should run on prod to save dart-internal capacity.

This seems to be occurring on linux_web_engine as well https://ci.chromium.org/ui/p/dart-internal/builders/flutter/Linux%20Production%20Engine%20Drone/31109/overview.

For the short term, we added some kvm bots to unblock the releases, but we should fix engine_v2 to trigger the tests outside dart-internal.

Steps to reproduce

No response

Expected results

Possible solutions

  1. Fix the JSON configs to do the correct thing
  2. Add a feature to the engine_v2 recipe so tests are spawned on bots from a different pool
@CaseyHillers CaseyHillers added the team-infra Owned by Infrastructure team label Jan 31, 2024
@godofredoc
Copy link
Contributor

KVM:1 should not have been added here: https://github.com/flutter/engine/pull/49940/files

@godofredoc
Copy link
Contributor

@CaseyHillers I don't see the failure in web_engine build, do you mean to add a different link for it?

@CaseyHillers
Copy link
Contributor Author

KVM:1 should not have been added here: https://github.com/flutter/engine/pull/49940/files

Prior discussion was at flutter/engine#49650 (comment). How should it be configured to run emulators?

@CaseyHillers I don't see the failure in web_engine build, do you mean to add a different link for it?

web_engine isn't failing, but the tests are running on dart-internal. See https://ci.chromium.org/ui/p/dart-internal/builders/flutter/Linux%20Production%20Engine%20Drone/31109/overview which is an example test shard that I would expect to run on the prod pool

@godofredoc
Copy link
Contributor

The tests need to be filtered on non release branches.

@godofredoc godofredoc added team-release and removed team-infra Owned by Infrastructure team labels Feb 29, 2024
@godofredoc godofredoc removed their assignment Feb 29, 2024
@godofredoc
Copy link
Contributor

This issue was introduced when the test was moved from the standalone builder to run as part of the fuchsia build.

@XilaiZhang XilaiZhang added P2 Important issues not at the top of the work list triaged-release labels Mar 6, 2024
@matanlurey
Copy link
Contributor

Closing as stale. Please feel free to open a new issue with a strong justification for doing this.

(To be clear, the -release and -infra teams have no plans to work on this in the known future)

@matanlurey matanlurey closed this as not planned Won't fix, can't repro, duplicate, stale May 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P2 Important issues not at the top of the work list
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@matanlurey @CaseyHillers @XilaiZhang @godofredoc
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy