-
Notifications
You must be signed in to change notification settings - Fork 28.9k
Open
Labels
P3Issues that are less important to the Flutter projectIssues that are less important to the Flutter projectc: new featureNothing broken; request for a new capabilityNothing broken; request for a new capabilityc: proposalA detailed proposal for a change to FlutterA detailed proposal for a change to Flutterteam-toolOwned by Flutter Tool teamOwned by Flutter Tool teamtoolAffects the "flutter" command-line tool. See also t: labels.Affects the "flutter" command-line tool. See also t: labels.tool-still-validIssues that have been deemed still valid as part of the Flutter Tools issue cleanup initiative.Issues that have been deemed still valid as part of the Flutter Tools issue cleanup initiative.triaged-toolTriaged by Flutter Tool teamTriaged by Flutter Tool team
Description
Use case
When using the --symbolize
option with an obfuscated stack-trace, the source-code paths appear to be absolute.
For example:
at #00 abs 00000070889bcc93 virt 000000000018fc93 _kDartIsolateSnapshotInstructions+0xb9153 (unparsed:null)
at #01 abs 00000070889464fb virt 00000000001194fb _kDartIsolateSnapshotInstructions+0x429bb (unparsed:null)
becomes:
at #0 _MyAppState.build.<anonymous closure> (/path/to/my/my_app/lib/main.dart:89:17)
at #1 _InkResponseState.handleTap (/path/to/my/sdk/flutter/packages/flutter/lib/src/material/ink_well.dart:1170:21)
In a normal (not obfuscated) stack-trace, the paths are all refer to the packages:
e.g.
at _MyAppState.build.<fn> line 113, column 24 (package:my_app/main.dart:113)
at _InkResponseState.handleTap line 1170, column 21 (package:flutter/src/material/ink_well.dart:1170)
Proposal
Looking at the symbols file with a hex editor, I can see that the paths are all absolute to my machine.
I wonder if it would be possible to store package relative paths instead in the symbol files, as they can be observed in non-obfuscated stack-traces.
Main reasons for this request are:
- Stack-traces are consistent between obfuscated and non-obfuscated apps.
- Stack-traces are consistent between machines/setups (as paths won't matter anymore).
- Shorter package relative paths are easier to read.
Metadata
Metadata
Assignees
Labels
P3Issues that are less important to the Flutter projectIssues that are less important to the Flutter projectc: new featureNothing broken; request for a new capabilityNothing broken; request for a new capabilityc: proposalA detailed proposal for a change to FlutterA detailed proposal for a change to Flutterteam-toolOwned by Flutter Tool teamOwned by Flutter Tool teamtoolAffects the "flutter" command-line tool. See also t: labels.Affects the "flutter" command-line tool. See also t: labels.tool-still-validIssues that have been deemed still valid as part of the Flutter Tools issue cleanup initiative.Issues that have been deemed still valid as part of the Flutter Tools issue cleanup initiative.triaged-toolTriaged by Flutter Tool teamTriaged by Flutter Tool team