Skip to content

[packages] Eliminate use of Pigeon dartHostTestHandler #159886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
2 of 16 tasks
stuartmorgan-g opened this issue Dec 6, 2024 · 0 comments
Open
2 of 16 tasks

[packages] Eliminate use of Pigeon dartHostTestHandler #159886

stuartmorgan-g opened this issue Dec 6, 2024 · 0 comments
Labels
c: contributor-productivity Team-specific productivity, code health, technical debt. P2 Important issues not at the top of the work list package flutter/packages repository. See also p: labels. team-ecosystem Owned by Ecosystem team triaged-ecosystem Triaged by Ecosystem team

Comments

@stuartmorgan-g
Copy link
Contributor

stuartmorgan-g commented Dec 6, 2024

In my experience doing Pigeon conversions of our plugins, dartHostTestHandler didn't make tests noticeably easier than simply mocking/faking/stubbing the host API class directly, and in some cases it was actually harder to use correctly to simulate things like exceptions. We have a robust test suite for Pigeon itself, so having package-level unit tests covering part of the Pigeon serialization isn't necessary, and the test generator is another generator we need to maintain.

We should try to eliminate all use of dartHostTestHandler in our own plugins, and if we are able to do so without any significant issues, remove the test generator from Pigeon entirely to reduce complexity and ongoing maintenance costs.

Current usage:

  • camera_android_camerax
  • file_selector_ios
  • file_selector_linux
  • file_selector_macos
  • file_selector_windows
  • image_picker_android
  • image_picker_ios
  • in_app_purchase_storekit
  • path_provider_android
  • path_provider_foundation
  • shared_preferences_android
  • shared_preferences_foundation
  • url_launcher_windows
  • video_player_android
  • video_player_avfoundation
  • webview_flutter_wkwebview
@stuartmorgan-g stuartmorgan-g added c: contributor-productivity Team-specific productivity, code health, technical debt. package flutter/packages repository. See also p: labels. team-ecosystem Owned by Ecosystem team P2 Important issues not at the top of the work list triaged-ecosystem Triaged by Ecosystem team labels Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: contributor-productivity Team-specific productivity, code health, technical debt. P2 Important issues not at the top of the work list package flutter/packages repository. See also p: labels. team-ecosystem Owned by Ecosystem team triaged-ecosystem Triaged by Ecosystem team
Projects
None yet
Development

No branches or pull requests

1 participant
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy