Skip to content

Bypass presubmits on bin/internal/engine.version updates #169139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jtmcdole opened this issue May 20, 2025 · 1 comment · Fixed by flutter/cocoon#4715
Closed

Bypass presubmits on bin/internal/engine.version updates #169139

jtmcdole opened this issue May 20, 2025 · 1 comment · Fixed by flutter/cocoon#4715
Assignees
@matanlurey
Labels
infra: cocoon Related to the dashboard or cocoon server infra: release Release-related requests and tooling P2 Important issues not at the top of the work list team-infra Owned by Infrastructure team triaged-infra Triaged by Infrastructure team

Comments

@jtmcdole
Copy link
Member

Release engineers have to update the engine.version file after accepting any cherry picks. This can take a while as autosubmit waits for all tests to pass (which they already did, in the last PR).

Proposal:

On PR Open:

  • If branch is release branch
  • And the only file changes is engine.version
  • And the contents of that file are the base sha

Action: close the MQG as successful.
@jtmcdole jtmcdole added team-infra Owned by Infrastructure team fyi-release P2 Important issues not at the top of the work list labels May 20, 2025
@matanlurey matanlurey added infra: release Release-related requests and tooling and removed fyi-release labels May 20, 2025
@matanlurey matanlurey self-assigned this May 20, 2025
@matanlurey matanlurey added infra: cocoon Related to the dashboard or cocoon server triaged-infra Triaged by Infrastructure team labels May 20, 2025
@matanlurey matanlurey changed the title [Cocoon][Feature] Bypass presubmits on engine.version updates (release branches) Bypass presubmits on bin/internal/engine.version updates May 20, 2025
@matanlurey
Copy link
Contributor

It should be safe to unconditionally skip presubmits for this file, similar to markdown files.

@matanlurey matanlurey mentioned this issue May 20, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matanlurey matanlurey

Labels
infra: cocoon Related to the dashboard or cocoon server infra: release Release-related requests and tooling P2 Important issues not at the top of the work list team-infra Owned by Infrastructure team triaged-infra Triaged by Infrastructure team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Opt out bin/internal/engine.version from most presubmits. matanlurey/cocoon
2 participants
@matanlurey @jtmcdole
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy