Skip to content

DialogTheme is missing the constraints property. #169326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
StanleyCocos opened this issue May 23, 2025 · 2 comments · May be fixed by #169327
Open

DialogTheme is missing the constraints property. #169326

StanleyCocos opened this issue May 23, 2025 · 2 comments · May be fixed by #169327
Labels
c: proposal A detailed proposal for a change to Flutter f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. team-design Owned by Design Languages team

Comments

@StanleyCocos
Copy link
Contributor

StanleyCocos commented May 23, 2025 •
edited
Loading

The idea of introducing constraints to the Dialog, which was proposed by Ramon Farizel, has already been accepted. However, it seems there are still some follow-up tasks that haven’t been addressed.

For example:

flutter/packages/flutter/lib/src/material/dialog_theme.dart

Line 49 in ca01dc1

Widget? child,

flutter/packages/flutter/lib/src/material/dialog.dart

Line 452 in ca01dc1

this.scrollable = false,

To be precise, features AlertDialog, SimpleDialog, ThemeData, and d are still missing this functionality.
This was referenced May 23, 2025
Open
Closed
@danagbemava-nc danagbemava-nc added in triage Presently being triaged by the triage team framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. c: proposal A detailed proposal for a change to Flutter team-design Owned by Design Languages team and removed in triage Presently being triaged by the triage team labels May 23, 2025
@QuncCccccc
Copy link
Contributor

Actually adding constraints in DialogThemeData but not adding it in DialogTheme is on purpose:)

We have this ongoing umbrella issue: #91772, and part of this issue is to normalize the component themes. Ideally, we hope the xWidgetTheme only contains xWidgetThemeData data and Widget child properties, so for example, in DialogTheme, its the properties (except data and child) have been commented "This property is obsolete and will be deprecated in a future release". So any newly-added properties should only be added in DialogThemeData:)

@StanleyCocos
Copy link
Contributor Author

@QuncCccccc Thank you.

Then is it valuable for AlertDialog and SimpleDialog as well? I came across this issue while studying the code. It seems to be a missing piece.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: proposal A detailed proposal for a change to Flutter f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. team-design Owned by Design Languages team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: DialogTheme is missing the constraints property. StanleyCocos/flutter
3 participants
@StanleyCocos @QuncCccccc @danagbemava-nc
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy