Skip to content

Consider Deprecating & Removing BitField and kMaxUnsignedSMI #27819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jonahwilliams opened this issue Feb 12, 2019 · 1 comment
Closed

Consider Deprecating & Removing BitField and kMaxUnsignedSMI #27819

jonahwilliams opened this issue Feb 12, 2019 · 1 comment
Labels
c: API break Backwards-incompatible API changes c: proposal A detailed proposal for a change to Flutter framework flutter/packages/flutter repository. See also f: labels. P2 Important issues not at the top of the work list team-framework Owned by Framework team triaged-framework Triaged by Framework team

Comments

@jonahwilliams
Copy link
Member

jonahwilliams commented Feb 12, 2019 •
edited by zoechi
Loading

The kMaxUnsignedSMI is based on and refers to smi and mints concepts from Dart 1. In Dart 2 all ints are 64 bits, making the current name and size inaccurate. It also cannot be accurately represented in JavaScript which only supports 32 bit ints. This poses issues for compilation, requiring either unsupported replacements or different behavior.

The BitField depends on this constant, but is also unused in the framework.

There were several new usages of the kMaxUnsignedSMI value which we should audit before introducing more.

cc @goderbauer @gspencergoog @Hixie
@jonahwilliams jonahwilliams added the framework flutter/packages/flutter repository. See also f: labels. label Feb 12, 2019
@Hixie
Copy link
Contributor

Hixie commented Feb 13, 2019

Seems like a good candidate for #24722

@zoechi zoechi added the c: API break Backwards-incompatible API changes label Feb 13, 2019
@kf6gpe kf6gpe changed the title Consider Deprecating & Removing BitField and kMaxUnsignedSMI Consider Deprecating & Removing BitField and kMaxUnsignedSMI Dec 20, 2019
@markusaksli-nc markusaksli-nc added passed first triage c: proposal A detailed proposal for a change to Flutter labels Jul 29, 2020
@goderbauer goderbauer added the P2 Important issues not at the top of the work list label Feb 21, 2023
@flutter-triage-bot flutter-triage-bot bot added team-framework Owned by Framework team triaged-framework Triaged by Framework team labels Jul 8, 2023
@jonahwilliams jonahwilliams closed this as not planned Won't fix, can't repro, duplicate, stale May 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: API break Backwards-incompatible API changes c: proposal A detailed proposal for a change to Flutter framework flutter/packages/flutter repository. See also f: labels. P2 Important issues not at the top of the work list team-framework Owned by Framework team triaged-framework Triaged by Framework team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@zoechi @Hixie @goderbauer @jonahwilliams @markusaksli-nc
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy