Skip to content

Revert "Hide text selection toolbar when dragging handles on mobile" #105247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 2, 2022
Merged

Revert "Hide text selection toolbar when dragging handles on mobile" #105247

merged 1 commit into from
Jun 2, 2022

Conversation

zanderso
Copy link
Member

@zanderso zanderso commented Jun 2, 2022

@flutter-dashboard flutter-dashboard bot added a: text input Entering text in a text field or keyboard related problems f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Jun 2, 2022
@zanderso zanderso added warning: land on red to fix tree breakage Override tree-status signal (land even with closed tree), combine with the autosubmit label. waiting for tree to go green labels Jun 2, 2022
gaaclarke
gaaclarke approved these changes Jun 2, 2022
View reviewed changes
Copy link
Member

@gaaclarke gaaclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zanderso zanderso merged commit d87b0dd into master Jun 2, 2022
@zanderso zanderso deleted the revert-104274-handle-hide-toolbar branch June 2, 2022 19:37
@zanderso
Copy link
Member Author

zanderso commented Jun 2, 2022

@markusaksli-nc

@zanderso
Copy link
Member Author

zanderso commented Jun 2, 2022

@justinmc

@justinmc
Copy link
Contributor

justinmc commented Jun 2, 2022

@markusaksli-nc Looks like it was just that the curly brace lint rule was added at the same time as your PR. Can you re-revert with that change?

@wanchana322 wanchana322 linked an issue Jun 3, 2022 that may be closed by this pull request
1 #105279
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 3, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2022
@engine-flutter-autoroll
d87b0dd Revert "Hide text selection toolbar when dragging handles on …
3777db1 
…mobile (#104274)" (flutter/flutter#105247)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 3, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2022
@engine-flutter-autoroll
d87b0dd Revert "Hide text selection toolbar when dragging handles on …
35e7a2f 
…mobile (#104274)" (flutter/flutter#105247)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 3, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2022
@engine-flutter-autoroll
d87b0dd Revert "Hide text selection toolbar when dragging handles on …
3aac2b5 
…mobile (#104274)" (flutter/flutter#105247)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 3, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 3, 2022
@engine-flutter-autoroll
d87b0dd Revert "Hide text selection toolbar when dragging handles on …
775bae7 
…mobile (#104274)" (flutter/flutter#105247)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 4, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2022
@engine-flutter-autoroll
d87b0dd Revert "Hide text selection toolbar when dragging handles on …
bff5626 
…mobile (#104274)" (flutter/flutter#105247)
markusaksli-nc added a commit that referenced this pull request Jun 4, 2022
@markusaksli-nc
Revert "Revert "Hide text selection toolbar when dragging handles on …
9ea26fc 
…mobile (#104274)" (#105247)"

This reverts commit d87b0dd.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 4, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2022
@engine-flutter-autoroll
d87b0dd Revert "Hide text selection toolbar when dragging handles on …
03d5ec2 
…mobile (#104274)" (flutter/flutter#105247)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 4, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2022
@engine-flutter-autoroll
d87b0dd Revert "Hide text selection toolbar when dragging handles on …
21788a9 
…mobile (#104274)" (flutter/flutter#105247)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 5, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2022
@engine-flutter-autoroll
d87b0dd Revert "Hide text selection toolbar when dragging handles on …
06b163a 
…mobile (#104274)" (flutter/flutter#105247)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 5, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2022
@engine-flutter-autoroll
d87b0dd Revert "Hide text selection toolbar when dragging handles on …
a420b24 
…mobile (#104274)" (flutter/flutter#105247)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 5, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2022
@engine-flutter-autoroll
d87b0dd Revert "Hide text selection toolbar when dragging handles on …
027f6a9 
…mobile (#104274)" (flutter/flutter#105247)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 6, 2022
@engine-flutter-autoroll
d87b0dd Revert "Hide text selection toolbar when dragging handles on …
51e6ed9 
…mobile (#104274)" (flutter/flutter#105247)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 6, 2022
@engine-flutter-autoroll
d87b0dd Revert "Hide text selection toolbar when dragging handles on …
b8ff9eb 
…mobile (#104274)" (flutter/flutter#105247)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 6, 2022
@engine-flutter-autoroll
d87b0dd Revert "Hide text selection toolbar when dragging handles on …
d5cf588 
…mobile (#104274)" (flutter/flutter#105247)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 6, 2022
@engine-flutter-autoroll
d87b0dd Revert "Hide text selection toolbar when dragging handles on …
4a7a384 
…mobile (#104274)" (flutter/flutter#105247)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 6, 2022
@engine-flutter-autoroll
d87b0dd Revert "Hide text selection toolbar when dragging handles on …
35c9528 
…mobile (#104274)" (flutter/flutter#105247)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
d87b0dd Revert "Hide text selection toolbar when dragging handles on …
5a76f32 
…mobile (#104274)" (flutter/flutter#105247)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
d87b0dd Revert "Hide text selection toolbar when dragging handles on …
8c923fb 
…mobile (#104274)" (flutter/flutter#105247)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
d87b0dd Revert "Hide text selection toolbar when dragging handles on …
4ccb524 
…mobile (#104274)" (flutter/flutter#105247)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
d87b0dd Revert "Hide text selection toolbar when dragging handles on …
bd90497 
…mobile (#104274)" (flutter/flutter#105247)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
d87b0dd Revert "Hide text selection toolbar when dragging handles on …
a3d5322 
…mobile (#104274)" (flutter/flutter#105247)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
d87b0dd Revert "Hide text selection toolbar when dragging handles on …
512499c 
…mobile (#104274)" (flutter/flutter#105247)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
d87b0dd Revert "Hide text selection toolbar when dragging handles on …
9ee35b7 
…mobile (#104274)" (flutter/flutter#105247)
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@zanderso @camsim99
Revert "Hide text selection toolbar when dragging handles on mobile (f…
b2b3136 
…lutter#104274)" (flutter#105247)

This reverts commit 4ec4c24.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
d87b0dd Revert "Hide text selection toolbar when dragging handles on …
447e984 
…mobile (#104274)" (flutter/flutter#105247)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
d87b0dd Revert "Hide text selection toolbar when dragging handles on …
d2710ec 
…mobile (#104274)" (flutter/flutter#105247)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaaclarke gaaclarke gaaclarke approved these changes

Assignees
No one assigned
Labels
a: text input Entering text in a text field or keyboard related problems f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. warning: land on red to fix tree breakage Override tree-status signal (land even with closed tree), combine with the autosubmit label.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1
3 participants
@zanderso @justinmc @gaaclarke
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy