Skip to content

[flutter_tools] migrate project-validate to analyze --suggestions #106149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jun 24, 2022
Merged

[flutter_tools] migrate project-validate to analyze --suggestions #106149

merged 11 commits into from
Jun 24, 2022

Conversation

Jasguerrero
Copy link
Contributor

@Jasguerrero Jasguerrero commented Jun 17, 2022 •
edited
Loading

#2885
As suggested by the team this should be a flag inside flutter analyze instead of a new command

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jun 17, 2022
@Jasguerrero Jasguerrero changed the title [flutter_tools] migrate project-validate to analyze --suggestion [flutter_tools] migrate project-validate to analyze --suggestions Jun 17, 2022
Jasguerrero
Jasguerrero commented Jun 17, 2022
View reviewed changes
christopherfujino
christopherfujino reviewed Jun 22, 2022
View reviewed changes
packages/flutter_tools/lib/src/commands/analyze.dart
@@ -56,6 +60,9 @@ class AnalyzeCommand extends FlutterCommand {
help: 'The path to write the request and response protocol. This is '
'only intended to be used for debugging the tooling.',
hide: !verboseHelp);
argParser.addOption('suggestions',
help: 'Show suggestions about the current flutter project.'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From reading the code, it sounds like it's not the "current" project, but whatever project is at the path pointed to by this option, right?

Copy link
Contributor

@christopherfujino christopherfujino Jun 22, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I suggest you make this usage consistent with the rest of flutter analyze (from a brief look at the code, there's a --current-package flag, that defaults to on, and then the argResults.rest is parsed as directories or files and canonicalized)

christopherfujino
christopherfujino reviewed Jun 23, 2022
View reviewed changes
packages/flutter_tools/lib/src/commands/analyze.dart Outdated
}
directoryPath = items.first;
}
else {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style nit: put this else on the previous line

christopherfujino
christopherfujino reviewed Jun 23, 2022
View reviewed changes
packages/flutter_tools/lib/src/commands/analyze.dart Outdated
@@ -119,7 +129,31 @@ class AnalyzeCommand extends FlutterCommand {

@override
Future<FlutterCommandResult> runCommand() async {
if (boolArgDeprecated('watch')) {
final bool? suggestionFlag = boolArg('suggestions');
final Set<String> items;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this can be declared where it is set, on line 141. If someone later adds code that tries to reference this outside the scope where it's initialized, it will be a runtime error that the compiler can't catch.

christopherfujino
christopherfujino reviewed Jun 23, 2022
View reviewed changes
@Jasguerrero Jasguerrero force-pushed the move_validate_to_flag branch from d882f6b to 8a62570 Compare June 23, 2022 23:46
christopherfujino
christopherfujino approved these changes Jun 24, 2022
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jasguerrero Jasguerrero added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 24, 2022
@auto-submit auto-submit bot merged commit ddd493b into flutter:master Jun 24, 2022
This was referenced Jun 25, 2022
Closed
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 25, 2022
@engine-flutter-autoroll
ddd493b [flutter_tools] migrate project-validate to analyze --suggest…
b95f3bf 
…ions (flutter/flutter#106149)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 25, 2022
@engine-flutter-autoroll
ddd493b [flutter_tools] migrate project-validate to analyze --suggest…
bea0a83 
…ions (flutter/flutter#106149)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 26, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 26, 2022
@engine-flutter-autoroll
ddd493b [flutter_tools] migrate project-validate to analyze --suggest…
03ea8c9 
…ions (flutter/flutter#106149)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 27, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 27, 2022
@engine-flutter-autoroll
ddd493b [flutter_tools] migrate project-validate to analyze --suggest…
39e195b 
…ions (flutter/flutter#106149)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 27, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 27, 2022
@engine-flutter-autoroll
ddd493b [flutter_tools] migrate project-validate to analyze --suggest…
25ac49b 
…ions (flutter/flutter#106149)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 27, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 27, 2022
@engine-flutter-autoroll
ddd493b [flutter_tools] migrate project-validate to analyze --suggest…
8e213c9 
…ions (flutter/flutter#106149)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 28, 2022
@engine-flutter-autoroll
ddd493b [flutter_tools] migrate project-validate to analyze --suggest…
ed671cc 
…ions (flutter/flutter#106149)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 28, 2022
@engine-flutter-autoroll
ddd493b [flutter_tools] migrate project-validate to analyze --suggest…
06f1229 
…ions (flutter/flutter#106149)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 28, 2022
@engine-flutter-autoroll
ddd493b [flutter_tools] migrate project-validate to analyze --suggest…
848c5f7 
…ions (flutter/flutter#106149)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 28, 2022
@engine-flutter-autoroll
ddd493b [flutter_tools] migrate project-validate to analyze --suggest…
48bf50b 
…ions (flutter/flutter#106149)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 28, 2022
@engine-flutter-autoroll
ddd493b [flutter_tools] migrate project-validate to analyze --suggest…
d58f7bc 
…ions (flutter/flutter#106149)
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@Jasguerrero @camsim99
[flutter_tools] migrate project-validate to analyze --suggestions (fl…
575e404 
…utter#106149)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
ddd493b [flutter_tools] migrate project-validate to analyze --suggest…
40a0619 
…ions (flutter/flutter#106149)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
ddd493b [flutter_tools] migrate project-validate to analyze --suggest…
3ac328a 
…ions (flutter/flutter#106149)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christopherfujino christopherfujino christopherfujino approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jasguerrero @christopherfujino
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy