It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

Hello @Piinks
I've added the tests, I've took inspiration from selectable_region_context_menu_test.dart

@GiacomoPignoni Thanks for the tests, but it looks like there are some failed checks now, can you take a look?

@justinmc I'm sorry but I'm not really good at understating the problem
I've solved the formatting issue, but it seems there still some error about SemanticsRole, even though I didn't touch it in this PR

Versions used: 6_1_0
Tokens used: 1040/2268

To see detailed version and token usage, run with --verbose (-v).
ELAPSED TIME: 0.809s for bin/cache/dart-sdk/bin/dart --enable-asserts dev/tools/gen_defaults/bin/gen_defaults.dart in /b/s/w/ir/x/w/flutter
▌01:15:28▐ Up to date integration test template files...
▌01:15:28▐ Analysis failed.
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
The error messages reported above are repeated here:
  -- This line intentionally left blank --  
Command: bin/flutter analyze --flutter-repo
Command exited with exit code 1 but expected zero exit code.
Working directory: /b/s/w/ir/x/w/flutter
stdout and stderr output:
Analyzing flutter...                                            

  error • The type 'SemanticsRole' is not exhaustively matched by the switch cases since it doesn't match 'SemanticsRole.status' • packages/flutter/lib/src/semantics/semantics.dart:106:67 • non_exhaustive_switch_expression

1 issue found. (ran in 234.1s)
  -- This line intentionally left blank --  
Dart analyzer failed when --watch was used.
Command: bin/flutter analyze --flutter-repo --watch --benchmark
Working directory: /b/s/w/ir/x/w/flutter
stdout and stderr output:
Analyzing Flutter repository...                                    19.0s


  error • The type 'SemanticsRole' is not exhaustively matched by the switch cases since it doesn't match 'SemanticsRole.status' • packages/flutter/lib/src/semantics/semantics.dart:106:67 • non_exhaustive_switch_expression
1 issue found. (1 new) • analyzed 5176 files (ran in 19.02s)
Analysis benchmark written to analysis_benchmark.json ({time: 19.017, issues: 1}).

━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
You may find the errors by searching for "╡ERROR #" in the logs.
╔═╡ERROR #1╞════════════════════════════════════════════════════════════════════
║ Command: dart --enable-asserts /b/s/w/ir/x/w/flutter/dev/bots/analyze.dart
║ Command exited with exit code 1 but expected zero exit code.
║ Working directory: /b/s/w/ir/x/w/flutter
╚═══════════════════════════════════════════════════════════════════════════════
▌01:15:28▐ Test failed.
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
The error messages reported above are repeated here:
  -- This line intentionally left blank --  
Command: dart --enable-asserts /b/s/w/ir/x/w/flutter/dev/bots/analyze.dart
Command exited with exit code 1 but expected zero exit code.
Working directory: /b/s/w/ir/x/w/flutter
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
You may find the errors by searching for "╡ERROR #" in the logs.

Hi @GiacomoPignoni have you tried rebasing with the tip of tree to resolve the issue?

@Piinks I'm sorry, I've tried to rebase multiple time but I still have 2 tests not passing for a timeout that are no related on my changes. I honestly don't know what to do

Those seemed like infra problems, I've rerun them.

Hello, I'm upping this since we're really looking into this fix that blocks us from migrating to Flutter 3.29

This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@GiacomoPignoni Hi! Are you able to address the comments above so we can work together to get this landed? This is a great addition and I'm looking forward to it!

Hello @dkwingsmt I will try to fix it during this week

Hello @dkwingsmt I've made the requested fix
I'm not sure about the tests, since now there is already a view factory specifically for the test. From my point of view this approach is wrong, since there is some logic replication and so the test are not testing the real logic.

I didn't see this PR before I started work on a separate fix myself. Rather than setting CSS properties on the <img> element, it actually calculates the size and position of the <img> element child. This way it's more testable since we can check that the actual computed size and clip are correct on the render object itself. My approach also works with different AlignmentGeometry values. I think this PR is superceded by #171916