Fix DropdownMenu does not apply opacity to the selected value when disabled #170336

huycozy · 2025-06-10T10:15:36Z

Description

The bug is about the effectiveTextStyle being applied to the inner TextField inside DropdownMenu fails to reflect the disabled style based on the enabled property.
The fix for this is simply to check the enabled property and override the TextField's TextStyle.

Demo of the fix

before	after
before.mov	after.mov

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

packages/flutter/lib/src/material/dropdown_menu.dart

…sabled Signed-off-by: huycozy <huy@nevercode.io>

…nu's in the disabled state Signed-off-by: huycozy <huy@nevercode.io>

QuncCccccc

Adding it in DropdownMenu theme sounds better. Thank you! LGTM.

…ue when disabled (flutter/flutter#170336)

huycozy self-assigned this Jun 10, 2025

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Jun 10, 2025

huycozy force-pushed the fix-dropdownmenu-opacity-selected-value-disabled-169942 branch from 8fc8dd2 to c57ae72 Compare June 10, 2025 11:39

huycozy marked this pull request as ready for review June 10, 2025 14:12

huycozy requested a review from QuncCccccc June 10, 2025 14:14

QuncCccccc reviewed Jun 25, 2025

View reviewed changes

packages/flutter/lib/src/material/dropdown_menu.dart Outdated Show resolved Hide resolved

huycozy requested a review from QuncCccccc June 30, 2025 09:40

huycozy added 2 commits June 30, 2025 16:43

Fix DropdownMenu does not apply opacity to the selected value when di…

864d411

…sabled Signed-off-by: huycozy <huy@nevercode.io>

Allow customization of the selected item text color in the DropdownMe…

b372da0

…nu's in the disabled state Signed-off-by: huycozy <huy@nevercode.io>

huycozy force-pushed the fix-dropdownmenu-opacity-selected-value-disabled-169942 branch from b2802ce to b372da0 Compare June 30, 2025 09:46

QuncCccccc approved these changes Jul 2, 2025

View reviewed changes

QuncCccccc added autosubmit Merge PR when tree becomes green via auto submit App and removed autosubmit Merge PR when tree becomes green via auto submit App labels Jul 2, 2025

auto-submit bot added this pull request to the merge queue Jul 2, 2025

Merged via the queue into flutter:master with commit c2aa518 Jul 2, 2025
72 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 2, 2025

huycozy deleted the fix-dropdownmenu-opacity-selected-value-disabled-169942 branch July 2, 2025 04:40

engine-flutter-autoroll mentioned this pull request Jul 2, 2025

Roll Flutter from 2773c0c8e15e to 1dfb59d2811c (115 revisions) flutter/packages#9546

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 2, 2025

c2aa5180f Fix DropdownMenu does not apply opacity to the selected val…

25c777c

…ue when disabled (flutter/flutter#170336)

engine-flutter-autoroll mentioned this pull request Jul 2, 2025

Roll Flutter from 2773c0c8e15e to 17848992dc09 (116 revisions) flutter/packages#9547

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 2, 2025

c2aa5180f Fix DropdownMenu does not apply opacity to the selected val…

41b7690

…ue when disabled (flutter/flutter#170336)

engine-flutter-autoroll mentioned this pull request Jul 2, 2025

Roll Flutter from 2773c0c8e15e to a69ba5da50db (117 revisions) flutter/packages#9548

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 2, 2025

c2aa5180f Fix DropdownMenu does not apply opacity to the selected val…

a1c66b8

…ue when disabled (flutter/flutter#170336)

engine-flutter-autoroll mentioned this pull request Jul 2, 2025

Roll Flutter from 2773c0c8e15e to c6f9e801b2e4 (118 revisions) flutter/packages#9549

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 2, 2025

c2aa5180f Fix DropdownMenu does not apply opacity to the selected val…

9c72463

…ue when disabled (flutter/flutter#170336)

engine-flutter-autoroll mentioned this pull request Jul 2, 2025

Roll Flutter from 2773c0c8e15e to 59ba3087e40d (119 revisions) flutter/packages#9550

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 2, 2025

c2aa5180f Fix DropdownMenu does not apply opacity to the selected val…

9f8a475

…ue when disabled (flutter/flutter#170336)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 3, 2025

c2aa5180f Fix DropdownMenu does not apply opacity to the selected val…

73e393f

…ue when disabled (flutter/flutter#170336)

engine-flutter-autoroll mentioned this pull request Jul 3, 2025

Roll Flutter from 2773c0c8e15e to 58f0988f49f6 (134 revisions) flutter/packages#9554

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 3, 2025

c2aa5180f Fix DropdownMenu does not apply opacity to the selected val…

6a4cf74

…ue when disabled (flutter/flutter#170336)

engine-flutter-autoroll mentioned this pull request Jul 3, 2025

Roll Flutter from 2773c0c8e15e to 4b387d0a0bf9 (135 revisions) flutter/packages#9555

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 3, 2025

c2aa5180f Fix DropdownMenu does not apply opacity to the selected val…

9d84921

…ue when disabled (flutter/flutter#170336)

engine-flutter-autoroll mentioned this pull request Jul 3, 2025

Roll Flutter from 2773c0c8e15e to d0d68fc0c820 (136 revisions) flutter/packages#9556

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 3, 2025

c2aa5180f Fix DropdownMenu does not apply opacity to the selected val…

bbcd2ff

…ue when disabled (flutter/flutter#170336)

engine-flutter-autoroll mentioned this pull request Jul 3, 2025

Roll Flutter from 2773c0c8e15e to 750b87f55171 (137 revisions) flutter/packages#9557

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 3, 2025

c2aa5180f Fix DropdownMenu does not apply opacity to the selected val…

8b80e17

…ue when disabled (flutter/flutter#170336)

engine-flutter-autoroll mentioned this pull request Jul 4, 2025

Roll Flutter from 2773c0c8e15e to 07073e911dd9 (141 revisions) flutter/packages#9558

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 4, 2025

c2aa5180f Fix DropdownMenu does not apply opacity to the selected val…

478c8f7

…ue when disabled (flutter/flutter#170336)

engine-flutter-autoroll mentioned this pull request Jul 4, 2025

Roll Flutter from 2773c0c8e15e to 7d5f2e902a2b (142 revisions) flutter/packages#9559

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 4, 2025

c2aa5180f Fix DropdownMenu does not apply opacity to the selected val…

b44f919

…ue when disabled (flutter/flutter#170336)

engine-flutter-autoroll mentioned this pull request Jul 4, 2025

Roll Flutter from 2773c0c8e15e to bcab634d60c8 (143 revisions) flutter/packages#9560

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 4, 2025

c2aa5180f Fix DropdownMenu does not apply opacity to the selected val…

d6d01f9

…ue when disabled (flutter/flutter#170336)

engine-flutter-autoroll mentioned this pull request Jul 5, 2025

Roll Flutter from 2773c0c8e15e to 03ef1ba910ca (147 revisions) flutter/packages#9561

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 5, 2025

c2aa5180f Fix DropdownMenu does not apply opacity to the selected val…

14513d6

…ue when disabled (flutter/flutter#170336)

engine-flutter-autoroll mentioned this pull request Jul 5, 2025

Roll Flutter from 2773c0c8e15e to 03ef1ba910ca (147 revisions) flutter/packages#9562

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 5, 2025

c2aa5180f Fix DropdownMenu does not apply opacity to the selected val…

5d7d0eb

…ue when disabled (flutter/flutter#170336)

engine-flutter-autoroll mentioned this pull request Jul 6, 2025

Roll Flutter from 2773c0c8e15e to 10cde0d157cb (148 revisions) flutter/packages#9563

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 6, 2025

c2aa5180f Fix DropdownMenu does not apply opacity to the selected val…

3bc092b

…ue when disabled (flutter/flutter#170336)

engine-flutter-autoroll mentioned this pull request Jul 6, 2025

Roll Flutter from 2773c0c8e15e to 160f2cbed84d (149 revisions) flutter/packages#9564

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 6, 2025

c2aa5180f Fix DropdownMenu does not apply opacity to the selected val…

c897dbd

…ue when disabled (flutter/flutter#170336)

engine-flutter-autoroll mentioned this pull request Jul 6, 2025

Roll Flutter from 2773c0c8e15e to 160f2cbed84d (149 revisions) flutter/packages#9565

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 6, 2025

c2aa5180f Fix DropdownMenu does not apply opacity to the selected val…

c965c48

…ue when disabled (flutter/flutter#170336)

engine-flutter-autoroll mentioned this pull request Jul 7, 2025

Roll Flutter from 2773c0c8e15e to d35bde5363d5 (152 revisions) flutter/packages#9573

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 7, 2025

c2aa5180f Fix DropdownMenu does not apply opacity to the selected val…

96b5626

…ue when disabled (flutter/flutter#170336)

engine-flutter-autoroll mentioned this pull request Jul 7, 2025

Roll Flutter from 2773c0c8e15e to d35bde5363d5 (152 revisions) flutter/packages#9575

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 7, 2025

c2aa5180f Fix DropdownMenu does not apply opacity to the selected val…

aaa6c1f

…ue when disabled (flutter/flutter#170336)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 7, 2025

c2aa5180f Fix DropdownMenu does not apply opacity to the selected val…

0a9d6a2

…ue when disabled (flutter/flutter#170336)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix DropdownMenu does not apply opacity to the selected value when disabled #170336

Fix DropdownMenu does not apply opacity to the selected value when disabled #170336

huycozy commented Jun 10, 2025

Uh oh!

Uh oh!

QuncCccccc left a comment •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Fix DropdownMenu does not apply opacity to the selected value when disabled #170336

Fix DropdownMenu does not apply opacity to the selected value when disabled #170336

Conversation

huycozy commented Jun 10, 2025

Description

Demo of the fix

Pre-launch Checklist

Uh oh!

Uh oh!

QuncCccccc left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

QuncCccccc left a comment •

edited

Loading