Skip to content

[ Widget Previews ] Support projects containing libraries with part files #171027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 25, 2025
Merged

[ Widget Previews ] Support projects containing libraries with part files #171027

merged 3 commits into from
Jun 25, 2025

Conversation

bkonyi
Copy link
Contributor

@bkonyi bkonyi commented Jun 23, 2025

Reworked the dependency model to be library based instead of script based in order to support libraries spanning multiple scripts.

Also refactored test logic to improve maintainability and simply writing tests against the PreviewDetector.

@bkonyi
[ Widget Previews ] Support projects containing libraries with part f…
e9fa9cb 
…iles

Reworked the dependency model to be library based instead of script
based in order to support libraries spanning multiple scripts.

Also refactored test logic to improve maintainability and simply writing
tests against the `PreviewDetector`.
@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jun 23, 2025
@bkonyi bkonyi requested a review from jyameo June 23, 2025 18:29
@bkonyi bkonyi requested a review from matanlurey as a code owner June 23, 2025 19:23
jyameo
jyameo approved these changes Jun 25, 2025
View reviewed changes
Copy link
Contributor

@jyameo jyameo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! nice improvement. Thanks for the great work.

@bkonyi bkonyi added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 25, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Jun 25, 2025
Merged via the queue into master with commit 5959600 Jun 25, 2025
151 checks passed
@auto-submit auto-submit bot deleted the preview_detector_parts branch June 25, 2025 16:44
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 25, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 27, 2025
@engine-flutter-autoroll
5959600e1 [ Widget Previews ] Support projects containing libraries w…
82b08ee 
…ith part files (flutter/flutter#171027)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 27, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 27, 2025
@engine-flutter-autoroll
5959600e1 [ Widget Previews ] Support projects containing libraries w…
7468f63 
…ith part files (flutter/flutter#171027)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 27, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 27, 2025
@engine-flutter-autoroll
5959600e1 [ Widget Previews ] Support projects containing libraries w…
3c4f4c1 
…ith part files (flutter/flutter#171027)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 27, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 27, 2025
@engine-flutter-autoroll
5959600e1 [ Widget Previews ] Support projects containing libraries w…
cfb44d1 
…ith part files (flutter/flutter#171027)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 27, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 28, 2025
@engine-flutter-autoroll
5959600e1 [ Widget Previews ] Support projects containing libraries w…
912b7d6 
…ith part files (flutter/flutter#171027)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 28, 2025
@engine-flutter-autoroll
5959600e1 [ Widget Previews ] Support projects containing libraries w…
680d950 
…ith part files (flutter/flutter#171027)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 28, 2025
@engine-flutter-autoroll
5959600e1 [ Widget Previews ] Support projects containing libraries w…
4408d9e 
…ith part files (flutter/flutter#171027)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 29, 2025
@engine-flutter-autoroll
5959600e1 [ Widget Previews ] Support projects containing libraries w…
bd623fa 
…ith part files (flutter/flutter#171027)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 29, 2025
@engine-flutter-autoroll
5959600e1 [ Widget Previews ] Support projects containing libraries w…
b7746a4 
…ith part files (flutter/flutter#171027)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 29, 2025
@engine-flutter-autoroll
5959600e1 [ Widget Previews ] Support projects containing libraries w…
671c03f 
…ith part files (flutter/flutter#171027)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 30, 2025
@engine-flutter-autoroll
5959600e1 [ Widget Previews ] Support projects containing libraries w…
00b2c40 
…ith part files (flutter/flutter#171027)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 30, 2025
@engine-flutter-autoroll
5959600e1 [ Widget Previews ] Support projects containing libraries w…
1fe903e 
…ith part files (flutter/flutter#171027)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 30, 2025
@engine-flutter-autoroll
5959600e1 [ Widget Previews ] Support projects containing libraries w…
f6a36ae 
…ith part files (flutter/flutter#171027)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 30, 2025
@engine-flutter-autoroll
5959600e1 [ Widget Previews ] Support projects containing libraries w…
1ecf86b 
…ith part files (flutter/flutter#171027)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 1, 2025
@engine-flutter-autoroll
5959600e1 [ Widget Previews ] Support projects containing libraries w…
226b18c 
…ith part files (flutter/flutter#171027)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 1, 2025
@engine-flutter-autoroll
5959600e1 [ Widget Previews ] Support projects containing libraries w…
b84f6b8 
…ith part files (flutter/flutter#171027)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 1, 2025
@engine-flutter-autoroll
5959600e1 [ Widget Previews ] Support projects containing libraries w…
902559e 
…ith part files (flutter/flutter#171027)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 1, 2025
@engine-flutter-autoroll
5959600e1 [ Widget Previews ] Support projects containing libraries w…
9ac3c9c 
…ith part files (flutter/flutter#171027)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 1, 2025
@engine-flutter-autoroll
5959600e1 [ Widget Previews ] Support projects containing libraries w…
393a139 
…ith part files (flutter/flutter#171027)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 1, 2025
@engine-flutter-autoroll
5959600e1 [ Widget Previews ] Support projects containing libraries w…
9d75069 
…ith part files (flutter/flutter#171027)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 1, 2025
@engine-flutter-autoroll
5959600e1 [ Widget Previews ] Support projects containing libraries w…
7261a08 
…ith part files (flutter/flutter#171027)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 1, 2025
@engine-flutter-autoroll
5959600e1 [ Widget Previews ] Support projects containing libraries w…
884a61d 
…ith part files (flutter/flutter#171027)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 2, 2025
@engine-flutter-autoroll
5959600e1 [ Widget Previews ] Support projects containing libraries w…
0aab881 
…ith part files (flutter/flutter#171027)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 2, 2025
@engine-flutter-autoroll
5959600e1 [ Widget Previews ] Support projects containing libraries w…
e10f419 
…ith part files (flutter/flutter#171027)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 2, 2025
@engine-flutter-autoroll
5959600e1 [ Widget Previews ] Support projects containing libraries w…
47fe263 
…ith part files (flutter/flutter#171027)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 2, 2025
@engine-flutter-autoroll
5959600e1 [ Widget Previews ] Support projects containing libraries w…
8727a8a 
…ith part files (flutter/flutter#171027)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 2, 2025
@engine-flutter-autoroll
5959600e1 [ Widget Previews ] Support projects containing libraries w…
08f9594 
…ith part files (flutter/flutter#171027)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 3, 2025
@engine-flutter-autoroll
5959600e1 [ Widget Previews ] Support projects containing libraries w…
d1d2412 
…ith part files (flutter/flutter#171027)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 3, 2025
@engine-flutter-autoroll
5959600e1 [ Widget Previews ] Support projects containing libraries w…
ef50859 
…ith part files (flutter/flutter#171027)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 3, 2025
@engine-flutter-autoroll
5959600e1 [ Widget Previews ] Support projects containing libraries w…
e8e4253 
…ith part files (flutter/flutter#171027)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 3, 2025
@engine-flutter-autoroll
5959600e1 [ Widget Previews ] Support projects containing libraries w…
442cbcd 
…ith part files (flutter/flutter#171027)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 3, 2025
@engine-flutter-autoroll
5959600e1 [ Widget Previews ] Support projects containing libraries w…
dd014cf 
…ith part files (flutter/flutter#171027)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 4, 2025
@engine-flutter-autoroll
5959600e1 [ Widget Previews ] Support projects containing libraries w…
43d5e90 
…ith part files (flutter/flutter#171027)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 4, 2025
@engine-flutter-autoroll
5959600e1 [ Widget Previews ] Support projects containing libraries w…
549017f 
…ith part files (flutter/flutter#171027)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 4, 2025
@engine-flutter-autoroll
5959600e1 [ Widget Previews ] Support projects containing libraries w…
5842038 
…ith part files (flutter/flutter#171027)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 5, 2025
@engine-flutter-autoroll
5959600e1 [ Widget Previews ] Support projects containing libraries w…
5d20732 
…ith part files (flutter/flutter#171027)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 5, 2025
@engine-flutter-autoroll
5959600e1 [ Widget Previews ] Support projects containing libraries w…
deb599f 
…ith part files (flutter/flutter#171027)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 6, 2025
@engine-flutter-autoroll
5959600e1 [ Widget Previews ] Support projects containing libraries w…
fbbc22d 
…ith part files (flutter/flutter#171027)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 6, 2025
@engine-flutter-autoroll
5959600e1 [ Widget Previews ] Support projects containing libraries w…
78125f0 
…ith part files (flutter/flutter#171027)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 6, 2025
@engine-flutter-autoroll
5959600e1 [ Widget Previews ] Support projects containing libraries w…
83c2312 
…ith part files (flutter/flutter#171027)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 7, 2025
@engine-flutter-autoroll
5959600e1 [ Widget Previews ] Support projects containing libraries w…
baae42e 
…ith part files (flutter/flutter#171027)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 7, 2025
@engine-flutter-autoroll
5959600e1 [ Widget Previews ] Support projects containing libraries w…
484e035 
…ith part files (flutter/flutter#171027)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 7, 2025
@engine-flutter-autoroll
5959600e1 [ Widget Previews ] Support projects containing libraries w…
46d4401 
…ith part files (flutter/flutter#171027)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyameo jyameo jyameo approved these changes

@matanlurey matanlurey Awaiting requested review from matanlurey matanlurey is a code owner

Assignees
No one assigned
Labels
tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bkonyi @jyameo
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy