Improve assertion message in EdgeInsetsDirectional.resolve
#172099
+46
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces the generic assertion in `EdgeInsetsDirectional.resolve` with `debugCheckCanResolveTextDirection`. This change provides a more helpful and descriptive error message when the `TextDirection` is null, improving the developer experience by clearly stating why the resolution failed and how to fix it. Fixes: flutter#171816
Replaces the generic assertion in `_MixedEdgeInsets.resolve` with `debugCheckCanResolveTextDirection`. This change provides a more helpful and descriptive error message when the `TextDirection` is null, improving the developer experience by clearly stating why the resolution failed and how to fix it. Fixes: flutter#171817
…esolve Adds a test case to ensure that calling `EdgeInsetsGeometry.resolve` with a null `TextDirection` throws a `FlutterError` with the expected improved message.
…olve Adds a test case that uses `add()` and `subtract()` methods to ensure that calling `_MixedEdgeInsets.resolve` with a null `TextDirection` throws a `FlutterError` with the expected improved message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the generic assertion in
EdgeInsetsDirectional.resolvewithdebugCheckCanResolveTextDirection.This change provides a more helpful and descriptive error message when the
TextDirectionis null, improving the developerexperience by clearly stating why the resolution failed and how to fix it.
Fixes: #171816, Fixes: #171817, also fixes #171812
Pre-launch Checklist
///).