Move iOS Flutter.framework thinning into copy assemble build target #77007
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmagman
commented
Mar 1, 2021
Comment on lines
+87
to
+88
| // Should only contain Flutter.framework and App.framework. | ||
| expect(frameworkDirectory.listSync().length, 2); |
There was a problem hiding this comment.
This will detect future regressions that could cause #76958.
This was referenced Mar 1, 2021
This was referenced Mar 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#76665 added a
ThinIosApplicationFrameworksassemble build target that output the thinned framework directly intoRunner.app/Frameworks. This had the side effect of leaving a.last_build_idfile in the bundle, which fails App Store validation.Instead, move the Flutter.framework architecture thinning out of its own assemble build target and into the existing
UnpackIOStarget. The framework will be copied from the artifacts cached and thinned in the same step. I could have keptThinIosApplicationFrameworkswithUnpackIOSas a dependency, but they really are one concept with the same inputs, outputs, and skip conditions.Fixes #76958
Closes #76886 (thinning will be skipped when copy is also skipped.