Bitcode strip Flutter.framework in assemble build target #77329
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmagman
commented
Mar 5, 2021
| local bitcode_flag="" | ||
| if [[ "$ENABLE_BITCODE" == "YES" ]]; then | ||
| if [[ "$ENABLE_BITCODE" == "YES" && "$ACTION" == "install" ]]; then |
There was a problem hiding this comment.
"$ACTION" == "install" is only true when archiving (for distribution or App Store submission).
jmagman
commented
Mar 5, 2021
| @@ -42,7 +42,7 @@ Future<bool> containsBitcode(String pathToBinary) async { | |||
| if (line.contains('segname __LLVM') && lines.length - index - 1 > 3) { | |||
| final String emptyBitcodeMarker = lines | |||
| .skip(index - 1) | |||
| .take(3) | |||
| .take(4) | |||
There was a problem hiding this comment.
Bug in the bitcode detection.
This was referenced Mar 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
xcode_backendscript stripped bitcode from theFlutter.frameworkwhen bitcode is off or when not archiving to reduce install app size.App.frameworkunless archiving.bitcode_stripflag from-r(which removes the bitcode section entirely) to-m(which leaves the bitcode marker). This seems safer to me in case bitcode gets switched off or on, and matches the Xcode default behavior.Added assemble target unit tests, but this is also already covered by existing tests like
flutter/dev/devicelab/bin/tasks/build_ios_framework_module_test.dart
Lines 433 to 435 in 3082a28
flutter/packages/flutter_tools/test/integration.shard/ios_content_validation_test.dart
Line 128 in 42c9e27
More of #77007