Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[in_app_purchase] update min Flutter version to 1.20.0 #3887

Merged
merged 1 commit into from
May 13, 2021
Merged

[in_app_purchase] update min Flutter version to 1.20.0 #3887

merged 1 commit into from
May 13, 2021

Conversation

cyanglaz
Copy link
Contributor

The plugin's iOS folder has been removed due to federation. This is to support no iOS folder:

pubspec.yaml allows Flutter SDK version prior to 1.20.0, which does not support having no `ios/` folder.
Please consider increasing the Flutter SDK requirement to ^1.20.0 or higher (environment.sdk.flutter) or create an `ios/` folder.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format. See plugin_tool format)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@cyanglaz cyanglaz requested a review from LHLL as a code owner May 13, 2021 13:09
@google-cla google-cla bot added the cla: yes label May 13, 2021
@cyanglaz cyanglaz requested a review from mvanbeusekom May 13, 2021 13:09
mvanbeusekom
mvanbeusekom approved these changes May 13, 2021
View reviewed changes
Copy link
Contributor

@mvanbeusekom mvanbeusekom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyanglaz cyanglaz added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label May 13, 2021
@cyanglaz cyanglaz merged commit 6f79c26 into flutter:master May 13, 2021
@cyanglaz cyanglaz deleted the iap_fix_pubspec branch May 13, 2021 13:32
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 19, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 19, 2021
@engine-flutter-autoroll
6f79c26 [in_app_purchase] update min Flutter version to 1.20.0 (flutt…
7ae3a80 
…er/plugins#3887)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 19, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 19, 2021
@engine-flutter-autoroll
6f79c26 [in_app_purchase] update min Flutter version to 1.20.0 (flutt…
6922d0d 
…er/plugins#3887)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 19, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 19, 2021
@engine-flutter-autoroll
6f79c26 [in_app_purchase] update min Flutter version to 1.20.0 (flutt…
d592fd5 
…er/plugins#3887)
fotiDim pushed a commit to fotiDim/plugins that referenced this pull request Sep 13, 2021
@fotiDim
[in_app_purchase] update min Flutter version to 1.20.0 (flutter#3887)
0289bd8
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mvanbeusekom mvanbeusekom mvanbeusekom approved these changes

@LHLL LHLL Awaiting requested review from LHLL

Assignees
No one assigned
Labels
cla: yes p: in_app_purchase platform-ios waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cyanglaz @mvanbeusekom @stuartmorgan-g
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy