Replies: 1 comment 8 replies
-
|
Does anyone have any updates? I experiencing the same issue |
Beta Was this translation helpful? Give feedback.
-
|
Hmm, I looked at a few projects and the types were in devDependencies and I wonder what's different in this one that requires the types to be in dependencies. |
Beta Was this translation helpful? Give feedback.
-
|
The react type is common enough where consuming apps almost always include it so you won't see any breakages. The other one, not so much so without it npm won't pull it as transitive dep. |
Beta Was this translation helpful? Give feedback.
-
|
Do you mind taking a look at some other repos that don't include @types in their dependencies? These are written in TypeScript.
|
Beta Was this translation helpful? Give feedback.
-
|
yeah they're wrong microsoft/types-publisher#81 (comment) |
Beta Was this translation helpful? Give feedback.
-
|
Ah, well, that's a good resolution for me – it's a real disagreement and not failure to communicate. Thanks. |
Beta Was this translation helpful? Give feedback.
-
This issue was closed by the stale bot but I experienced it and it seems to be unresolved: #3682
Could it perhaps be fixed just by moving the @types packages from dependencies to devDependencies?
https://github.com/formatjs/formatjs/blob/main/packages/react-intl/package.json#L137
Beta Was this translation helpful? Give feedback.
All reactions