Skip to content

Commit a8d3a0e

Browse files
committed
Updated mapquest provider to have api key functionality
1 parent 62573c3 commit a8d3a0e

File tree

5 files changed

+11
-11
lines changed

5 files changed

+11
-11
lines changed

dist/geocoder.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

example/mapquest.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
<script src="../dist/geocoder.js"></script>
66
<script>
77
var mapQuestGeocoder = new GeocoderJS.createGeocoder('mapquest');
8-
mapQuestGeocoder.geocode('Washington, DC', function(result) {
8+
mapQuestGeocoder.geocode('1600 Pennsylvania Avenue NW, Washington, DC 20500', function(result) {
99
console.log(result);
1010
});
1111

spec/runner.html

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,6 @@
2828

2929
<script src="../src/providers/GoogleAPIProvider.js"></script>
3030

31-
<script src="../src/providers/GoogleProvider.js"></script>
32-
3331
<script src="../src/providers/MapquestProvider.js"></script>
3432

3533
<script src="GeoJSONDumper.spec.js"></script>
@@ -40,8 +38,6 @@
4038

4139
<script src="providers/GoogleAPIProvider.spec.js"></script>
4240

43-
<script src="providers/GoogleProvider.spec.js"></script>
44-
4541
<script src="providers/MapquestProvider.spec.js"></script>
4642

4743
<script src="providers/ProviderBase.spec.js"></script>

src/GeocoderProviderFactory.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,10 +28,10 @@ if (typeof GeocoderJS === "undefined" && typeof require === "function") {
2828

2929
switch (options.provider) {
3030
case 'google':
31-
provider = new GeocoderJS.GoogleAPIProvider();
31+
provider = new GeocoderJS.GoogleAPIProvider(options);
3232
break;
3333
case 'mapquest':
34-
provider = new GeocoderJS.MapquestProvider();
34+
provider = new GeocoderJS.MapquestProvider(options);
3535
break;
3636
}
3737

src/providers/MapquestProvider.js

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,9 @@ if (typeof GeocoderJS === "undefined" && typeof require === "function") {
1515
};
1616

1717
for (var i in defaults) {
18-
options[i] = defaults[i];
18+
if (options[i] === undefined) {
19+
options[i] = defaults[i];
20+
}
1921
}
2022

2123
this.apiKey = options.apiKey;
@@ -42,10 +44,12 @@ if (typeof GeocoderJS === "undefined" && typeof require === "function") {
4244
GeocoderJS.MapquestProvider.prototype.executeRequest = function(params, callback) {
4345
var req = new XMLHttpRequest(),
4446
requestUrl = 'http://open.mapquestapi.com/geocoding/v1/address?outFormat=json&location=' + encodeURIComponent(params.location);
45-
console.log(requestUrl);
47+
48+
if (this.apiKey) {
49+
requestUrl += '&key=' + this.apiKey;
50+
}
4651

4752
req.onload = function () {
48-
console.log(this);
4953
if (this.status != 200) {
5054
console.log("Received HTTP status code " + this.status + " when attempting geocoding request.");
5155
return callback(null);

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy