HTTP Method always blank in "Backend Performance" #924

arp242 · 2024-12-10T11:41:52Z

arp242
Dec 10, 2024

I configured Sentry to record performance. Overall this works reasonably well, but the HTTP method is always blank:

Try as I might, I just can't get it to show up; my little middleware:

func metrics() func(http.Handler) http.Handler {
	return func(next http.Handler) http.Handler {
		return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
			// Get path from router, so "/api/2/roles/4" shows up as "/api/2/roles/{role_id}"
			rctx := chi.RouteContext(r.Context())
			p := rctx.RoutePath
			if p == "" && len(rctx.RoutePatterns) > 0 {
				p = rctx.RoutePatterns[0]
			}
			if p == "" {
				p = r.URL.Path
			}
			if r.Method == "" {
				r.Method = "GET"
			}

			tx := sentry.StartTransaction(r.Context(), r.Method+" "+p,
				sentry.WithOpName("http.server"),
				sentry.ContinueFromRequest(r),
				sentry.WithTransactionSource(sentry.SourceRoute))
			tx.Data = map[string]any{
				"http.method": r.Method,
				"httpmethod":  r.Method,
				"http_method": r.Method,
				"method":      r.Method,
			}
			tx.Tags = map[string]string{
				"http.method": r.Method,
				"httpmethod":  r.Method,
				"http_method": r.Method,
				"method":      r.Method,
			}
			defer tx.Finish()
			*r = *r.WithContext(tx.Context())

			next.ServeHTTP(w, r)

			type statusWriter interface{ Status() int }
			ww, ok := w.(statusWriter)
			if ok && ww.Status() > 0 {
				tx.Status = sentry.HTTPtoSpanStatus(ww.Status())
			}
		})
	}
}

Those Data and Tags fields get recorded, but not as the method:

I suppose just GET /api/2/collections/{collection_id} is workable, but it looks very odd.

I'm not sure if I'm doing anything wrong or if it's a bug in the Go library?

Using 0.30.0 of this library. With Go 1.23.4.

cleptric · 2024-12-10T12:42:23Z

cleptric
Dec 10, 2024
Maintainer

Try to set http.request.method, like we do for e.g. Gin https://github.com/getsentry/sentry-go/blob/master/gin/sentrygin.go#L86.

0 replies

arp242 · 2024-12-10T12:58:32Z

arp242
Dec 10, 2024
Author

Seems the same:

JSON for the top event:

{
    "_metrics":             {"bytes.ingested.event": 6844, "bytes.stored.event": 7531},
    "culprit":              "GET /api/2/metadata",
    "datetime":             "2024-12-10T12:50:37.637395+00:00",
    "dist":                 null,
    "event_id":             "0fa4e709ad734711936bbb80332f4398",
    "grouping_config":      {"enhancements": "KLUv_SAYwQAAkwKRs25ld3N0eWxlOjIwMjMtMDEtMTGQ", "id": "newstyle:2023-01-11"},
    "ingest_path":          [{"public_key": "XE7QiyuNlja9PZ7I9qJlwQotzecWrUIN91BAO7Q5R38", "version": "24.11.1"}],
    "key_id":               "4145757",
    "level":                "info",
    "location":             "GET /api/2/metadata",
    "logger":               "",
    "message":              "",
    "metadata":             {"location": "GET /api/2/metadata", "title": "GET /api/2/metadata"},
    "nodestore_insert":     1733835041.074713,
    "platform":             "go",
    "project":              4508296333754368,
    "received":             1733835037.649069,
    "release":              "e2dc60a-dirty",
    "span_grouping_config": {"id": "default:2022-10-27"},
    "spans":                [],
    "start_timestamp":      1733835037.633819,
    "timestamp":            1733835037.637395,
    "title":                "GET /api/2/metadata",
    "transaction":          "GET /api/2/metadata",
    "transaction_info":     {"source": "route"},
    "type":                 "transaction",
    "version":              "7",
    "_dsc": {
        "environment": null,
        "public_key":  "9a68e69d89717efe5d74ed155c06ecad",
        "release":     "e2dc60a-dirty",
        "replay_id":   null,
        "sample_rate": "1.0",
        "sampled":     true,
        "trace_id":    "53e4b6cc-df15-284e-ae23-902aff0281d1",
        "transaction": "GET /api/2/metadata"
    },
    "contexts": {
        "device": {"arch": "amd64", "num_cpu": 16, "type": "device"},
        "os":     {"name": "linux", "type": "os"},
        "runtime": {
            "go_maxprocs":    16,
            "go_numcgocalls": 0,
            "go_numroutines": 56,
            "name":           "go",
            "runtime":        "go go1.23.4",
            "type":           "runtime",
            "version":        "go1.23.4"
        },
        "trace": {
            "client_sample_rate": 1,
            "exclusive_time":     3.576472,
            "hash":               "394c45aae5193a4e",
            "op":                 "http.server",
            "span_id":            "91a0edb89e6db667",
            "status":             "ok",
            "trace_id":           "53e4b6ccdf15284eae23902aff0281d1",
            "type":               "trace"
        }
    },
    "extra": {
        "http.request.method":       "GET",
        "http.request.size":         536,
        "http.response.size":        214328,
        "http.response.status_code": 200
    },
    "modules": {
		...
    },
    "sdk": {
        "name":     "sentry.go",
        "packages": [{"name": "sentry-go", "version": "0.30.0"}],
        "version":  "0.30.0",
        "integrations": ["ContextifyFrames", "Environment", "GlobalTags", "IgnoreErrors", "IgnoreTransactions", "Modules"]
    },
    "tags": [
        ["level", "info"],
        ["os.name", "linux"],
        ["runtime", "go go1.23.4"],
        ["runtime.name", "go"],
        ["release", "e2dc60a-dirty"],
        ["server_name", "x13.arp242.net"],
        ["transaction", "GET /api/2/metadata"]
    ]
}

So it's in there, but doesn't display as "HTTP Method"

The Extra/additional data also shows rather oddly in the UI:

But I think that's an UI issue(?)

0 replies

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

HTTP Method always blank in "Backend Performance" #924

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{editor}}'s edit

{{editor}}'s edit

Uh oh!

Replies: 2 comments

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{title}}

Uh oh!

Select a reply

Uh oh!

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

HTTP Method always blank in "Backend Performance" #924

Uh oh!

Uh oh!

arp242 Dec 10, 2024

Replies: 2 comments

Uh oh!

cleptric Dec 10, 2024 Maintainer

Uh oh!

arp242 Dec 10, 2024 Author

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

arp242
Dec 10, 2024

cleptric
Dec 10, 2024
Maintainer

arp242
Dec 10, 2024
Author