-
-
Notifications
You must be signed in to change notification settings - Fork 454
fix(replay): Inconsistent segment_id #4471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…try/sentry-java into markushi/fix/stretched-dialogs-sr
* fix(replay): Fix window tracking * api dump
Performance metrics 🚀
|
stefanosiano
approved these changes
Jun 5, 2025
romtsn
added a commit
that referenced
this pull request
Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
I noticed the segment_ids sometimes were not aligned and had gaps and figured it was due to multi-threading. So i opted for always changing
currentSegment
from within the replay-executor thread and using it directly as opposed to capturing its value outside the runnable.💡 Motivation and Context
Local findings
💚 How did you test it?
Manually + existing tests should cover it
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps