Skip to content

fix(replay): Inconsistent segment_id #4471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Jun 5, 2025
Merged

Conversation

romtsn
Copy link
Member

@romtsn romtsn commented Jun 5, 2025

📜 Description

I noticed the segment_ids sometimes were not aligned and had gaps and figured it was due to multi-threading. So i opted for always changing currentSegment from within the replay-executor thread and using it directly as opposed to capturing its value outside the runnable.

💡 Motivation and Context

Local findings

💚 How did you test it?

Manually + existing tests should cover it

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link
Contributor

github-actions bot commented Jun 5, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 377.02 ms 377.96 ms 0.94 ms
Size 1.58 MiB 2.08 MiB 511.08 KiB

@romtsn romtsn merged commit a33339c into main Jun 5, 2025
34 checks passed
@romtsn romtsn deleted the rz/fix/session-replay-segmentid branch June 5, 2025 15:07
romtsn added a commit that referenced this pull request Jul 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy