feat: Sample everything 100% w/ Spotlight & no DSN set (#4207)

BYK · szokeasaurusrex · web-flow · commit 3b28649994cb · 2025-03-28T11:05:38.000Z
This patch makes Spotlight easier to setup by turning all sampling to
100% when no DSN is set and Spotlight is enabled. I consider this a
non-breaking and a safe change as these only apply when no DSN is set so
it should have no production or billing implications.

---------

Co-authored-by: Daniel Szoke &lt;7881302+szokeasaurusrex@users.noreply.github.com&gt;
diff --git a/sentry_sdk/client.py b/sentry_sdk/client.py
@@ -417,6 +417,12 @@ def _capture_envelope(envelope):
 
             if self.options.get("spotlight"):
                 self.spotlight = setup_spotlight(self.options)
+                if not self.options["dsn"]:
+                    sample_all = lambda *_args, **_kwargs: 1.0
+                    self.options["send_default_pii"] = True
+                    self.options["error_sampler"] = sample_all
+                    self.options["traces_sampler"] = sample_all
+                    self.options["profiles_sampler"] = sample_all
 
             sdk_name = get_sdk_name(list(self.integrations.keys()))
             SDK_INFO["name"] = sdk_name
@@ -468,11 +474,7 @@ def should_send_default_pii(self):
 
         Returns whether the client should send default PII (Personally Identifiable Information) data to Sentry.
         """
-        result = self.options.get("send_default_pii")
-        if result is None:
-            result = not self.options["dsn"] and self.spotlight is not None
-
-        return result
+        return self.options.get("send_default_pii") or False
 
     @property
     def dsn(self):
