-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option to setup integrations filter #601
Comments
I am sure someone more in the Symfony know will be able to elaborate but shouldn't it look more like this: https://docs.sentry.io/platforms/php/guides/symfony/configuration/symfony-options/#callables? |
That's not the issue. The class I used is implemented to have
The issue with integrations is that in the current version it always wants an array and passing a callback isn't allowed despite what the error message says. |
This seems to be the case... sentry-symfony/src/DependencyInjection/Configuration.php Lines 54 to 56 in 3a16fdc
|
This comment was marked as outdated.
This comment was marked as outdated.
Bump |
This doesn't look like a bug, but rather a missing feature: looking at the code of version |
Ah yeah I got confused... it was implemented in sentry-php but sentry-symfony was never adapted to support it. |
Note: I wanted to disable ModulesIntegration since the package versions are useless traffic for us but once again I ran into this exact issue. :( |
sentry-php allows integrations option to be either a custom list of integrations or a callable what can filter the existing integrations:
https://github.com/getsentry/sentry-php/blob/ea704bbe145657a507d73cd8bf6cc017d269fffa/src/Options.php#L754
I'd like to use the latter but it seems the sentry-symfony package doesn't allow this. At least we were unable to find a working configuration:
It seems like this was implemented before (#279) but got broken in 4.0? Unless my yaml is incorrect in which case please advise what's the correct way.
We want to disable the error handling integrations because they were causing weird issues for us. But we want to keep the other default integrations.
The text was updated successfully, but these errors were encountered: