Java: use overlayChangedFiles in discard prediactes

nickrolfe · nickrolfe · commit 18f6ae5ef460 · 2025-07-10T11:12:29.000+01:00
diff --git a/java/ql/lib/semmle/code/Location.qll b/java/ql/lib/semmle/code/Location.qll
@@ -233,5 +233,5 @@ private predicate discardableLocation(string file, @location l) {
 /** Discard base locations in files fully extracted in the overlay. */
 overlay[discard_entity]
 private predicate discardLocation(@location l) {
-  exists(string file | discardableLocation(file, l) and extractedInOverlay(file))
+  exists(string file | discardableLocation(file, l) and overlayChangedFiles(file))
 }
diff --git a/java/ql/lib/semmle/code/java/Overlay.qll b/java/ql/lib/semmle/code/java/Overlay.qll
@@ -30,15 +30,6 @@ string getRawFileForLoc(@location l) {
   exists(@file f | locations_default(l, f, _, _, _, _) and files(f, result))
 }
 
-/** Holds for files fully extracted in the overlay. */
-overlay[local]
-predicate extractedInOverlay(string file) {
-  isOverlay() and
-  // numlines is used to restrict attention to fully extracted files and
-  // ignore skeleton extracted files in the overlay
-  exists(@locatable l | numlines(l, _, _, _) and file = getRawFile(l))
-}
-
 /**
  * A `@locatable` that should be discarded in the base variant if its file is
  * extracted in the overlay variant.
@@ -54,7 +45,7 @@ abstract class DiscardableLocatable extends @locatable {
 
 overlay[discard_entity]
 private predicate discardLocatable(@locatable el) {
-  extractedInOverlay(el.(DiscardableLocatable).getRawFileInBase())
+  overlayChangedFiles(el.(DiscardableLocatable).getRawFileInBase())
 }
 
 /**
@@ -77,7 +68,7 @@ abstract class DiscardableReferableLocatable extends @locatable {
 overlay[discard_entity]
 private predicate discardReferableLocatable(@locatable el) {
   exists(DiscardableReferableLocatable drl | drl = el |
-    extractedInOverlay(drl.getRawFileInBase()) and
+    overlayChangedFiles(drl.getRawFileInBase()) and
     not drl.existsInOverlay()
   )
 }

Original file line number	Diff line number	Diff line change
`@@ -233,5 +233,5 @@ private predicate discardableLocation(string file, @location l) {`
`233`	`233`	`/** Discard base locations in files fully extracted in the overlay. */`
`234`	`234`	`overlay[discard_entity]`
`235`	`235`	`private predicate discardLocation(@location l) {`
`236`		`- exists(string file \| discardableLocation(file, l) and extractedInOverlay(file))`
	`236`	`+ exists(string file \| discardableLocation(file, l) and overlayChangedFiles(file))`
`237`	`237`	`}`