Go: Add BigQuery as a sink for SQLi queries #2 #19561
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for treating cloud.google.com/go/bigquery.Client.Query as a SQL-injection sink in CodeQL analyses, along with test scaffolding, expected outputs, and a change note.
- Introduce a Go test module (
bigquery.go,go.mod) demonstrating an untrusted string passed toClient.Query. - Add CodeQL test query (
bigquery.ql) and sink model (cloud.google.com.go.bigquery.model.yml) to markQueryas an SQLi sink. - Provide test expectations and change notes (
*.expected,*.md).
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| go/ql/test/library-tests/semmle/go/frameworks/SQL/bigquery/go.mod | New module with BigQuery dependency for tests |
| go/ql/test/library-tests/semmle/go/frameworks/SQL/bigquery/bigquery.ql | CodeQL test that matches calls to BigQuery Query |
| go/ql/test/library-tests/semmle/go/frameworks/SQL/bigquery/bigquery.go | Example Go code invoking Query with untrusted data |
| go/ql/test/library-tests/semmle/go/frameworks/SQL/bigquery/bigquery.expected | Expected test output for the BigQuery sink |
| go/ql/test/library-tests/semmle/go/frameworks/SQL/bigquery/QueryString.ql | Test modules for SQL::QueryString and dataflow validation |
| go/ql/test/library-tests/semmle/go/frameworks/SQL/bigquery/QueryString.expected | Expected results placeholder for QueryString tests |
| go/ql/lib/ext/cloud.google.com.go.bigquery.model.yml | Extension model marking Client.Query as a SQLi sink |
| go/ql/lib/change-notes/2025-05-22-bigquery-client-query-sql-injection.md | Documentation of the newly recognized sink |
Comments suppressed due to low confidence (2)
go/ql/test/library-tests/semmle/go/frameworks/SQL/bigquery/bigquery.ql:3
- [nitpick] The variables
aandbare not descriptive. Consider renaming them topackageNameandfunctionName(or similar) to clarify their roles inhasQualifiedName.
from SQL::QueryString qs, Function func, string a, string b
go/ql/test/library-tests/semmle/go/frameworks/SQL/bigquery/QueryString.ql:24
- This forces
elementto be empty, which prevents capturing the actual query string in the QueryString test. Update this toelement = qs.toString()(or remove the filter) so the test can validate the real value.
element = "" and
7 tasks
Click to show differences in coveragegoGenerated file changes for go
+ `bigquery <https://pkg.go.dev/cloud.google.com/go/bigquery>`_,``cloud.google.com/go/bigquery*``,,,1
- `gorqlite <https://github.com/rqlite/gorqlite>`_,"``github.com/raindog308/gorqlite*``, ``github.com/rqlite/gorqlite*``",16,4,48
+ `gorqlite <https://github.com/rqlite/gorqlite>`_,"``github.com/raindog308/gorqlite*``, ``github.com/rqlite/gorqlite*``, ``github.com/kanikanema/gorqlite*``",24,6,72
- Others,``github.com/kanikanema/gorqlite``,8,2,24
- Totals,,688,1069,1556
+ Totals,,688,1069,1557
+ cloud.google.com/go/bigquery,1,,,,,,,,,,,,,,1,,,,,,,,,,,, |
Also fix up github.com/kanikanema/gorqlite
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #18460.