Java: Add support to ModuleImportDeclaration
#20097
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ModuleImportDeclaration
16b0695 to
a16147c
Compare
a24e4ae to
27cb373
Compare
IdrissRio
commented
Jul 30, 2025
| } | ||
| } | ||
|
|
||
| // Diagnostic Matches: Unknown location for jdk.internal.RequiresIdentity+Annotation |
There was a problem hiding this comment.
This is an internally generated annotation without a specific source location.
Excluding it from diagnostic will be addressed in a separate PR.
27cb373 to
e4848e0
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for Java 25 module import declarations, implementing the new import module syntax feature. The implementation includes database schema updates, a new ModuleImportDeclaration class, and comprehensive test coverage.
Key changes:
- Database schema updated to handle the new module import kind (value 6 in imports table)
- Added
ModuleImportDeclarationclass extendingImportwith methods to access module information and imported types/packages - Upgrade/downgrade scripts for database compatibility
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| java/ql/lib/semmle/code/java/Import.qll | Adds ModuleImportDeclaration class with methods to get module info and imported types/packages |
| java/ql/lib/config/semmlecode.dbscheme | Updates imports table schema to include module import kind (6) with documentation |
| java/ql/lib/upgrades/.../semmlecode.dbscheme | New schema version adding MODULEIMPORT kind to imports documentation |
| java/ql/lib/upgrades/.../old.dbscheme | Previous schema version for upgrade compatibility |
| java/ql/lib/upgrades/.../upgrade.properties | Upgrade script properties for module import declarations |
| java/downgrades/.../semmlecode.dbscheme | Downgrade schema removing module import support |
| java/downgrades/.../upgrade.properties | Downgrade script properties |
| java/ql/test/library-tests/module-import-declarations/* | Test files validating module import functionality and expected outputs |
| java/ql/lib/change-notes/2025-07-21-module-import-declarations.md | Release note documenting the new feature |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for Java 25 module import declarations:
ModuleImportDeclarationclass