No more duplicate commands in the sidebar while recording. Fixes SeleniumHQ#396

samitbadle · samitbadle · commit 4f86f013a6b1 · 2015-04-18T15:18:33.000+02:00
diff --git a/ide/main/src/content/selenium-ide-loader.js b/ide/main/src/content/selenium-ide-loader.js
@@ -45,14 +45,15 @@ SeleniumIDE.Loader.getEditors = function () {
   }
   var wm = Components.classes["@mozilla.org/appshell/window-mediator;1"].getService(Components.interfaces.nsIWindowMediator);
   var editorWindow = wm.getMostRecentWindow('global:selenium-ide');
-  if (editorWindow && editorWindow.editor) {
+  if (editorWindow && editorWindow.editor && editors.indexOf(editorWindow.editor) == -1) {
     editors.push(editorWindow.editor);
   }
   var mainWindow = wm.getMostRecentWindow("navigator:browser");
   editor = this.getSidebarEditor(mainWindow.document);
-  if (editor) {
+  if (editor && editors.indexOf(editor) == -1) {
     editors.push(editor);
   }
+
   return editors;
 };
 

Original file line number	Diff line number	Diff line change
`@@ -45,14 +45,15 @@ SeleniumIDE.Loader.getEditors = function () {`
`45`	`45`	`}`
`46`	`46`	`var wm = Components.classes["@mozilla.org/appshell/window-mediator;1"].getService(Components.interfaces.nsIWindowMediator);`
`47`	`47`	`var editorWindow = wm.getMostRecentWindow('global:selenium-ide');`
`48`		`- if (editorWindow && editorWindow.editor) {`
	`48`	`+ if (editorWindow && editorWindow.editor && editors.indexOf(editorWindow.editor) == -1) {`
`49`	`49`	`editors.push(editorWindow.editor);`
`50`	`50`	`}`
`51`	`51`	`var mainWindow = wm.getMostRecentWindow("navigator:browser");`
`52`	`52`	`editor = this.getSidebarEditor(mainWindow.document);`
`53`		`- if (editor) {`
	`53`	`+ if (editor && editors.indexOf(editor) == -1) {`
`54`	`54`	`editors.push(editor);`
`55`	`55`	`}`
	`56`	`+`
`56`	`57`	`return editors;`
`57`	`58`	`};`
`58`	`59`