Fix Git.transform_kwarg

FrNecas · Sebastian Thiel · commit 5b27339b0d7d · 2019-08-14T18:05:33.000+08:00
Kwargs were not transformed correctly if a value was set to 0 due to
wrong if condition.

Signed-off-by: František Nečas &lt;fifinecas@seznam.cz&gt;
diff --git a/git/cmd.py b/git/cmd.py
@@ -893,7 +893,7 @@ def transform_kwarg(self, name, value, split_single_char_options):
         else:
             if value is True:
                 return ["--%s" % dashify(name)]
-            elif value not in (False, None):
+            elif value is not False and value is not None:
                 return ["--%s=%s" % (dashify(name), value)]
         return []
 
diff --git a/git/test/test_git.py b/git/test/test_git.py
@@ -86,6 +86,7 @@ def test_it_transforms_kwargs_into_git_command_arguments(self):
 
         assert_equal(["--max-count"], self.git.transform_kwargs(**{'max_count': True}))
         assert_equal(["--max-count=5"], self.git.transform_kwargs(**{'max_count': 5}))
+        assert_equal(["--max-count=0"], self.git.transform_kwargs(**{'max_count': 0}))
         assert_equal([], self.git.transform_kwargs(**{'max_count': None}))
 
         # Multiple args are supported by using lists/tuples
