go-python
diff --git a/‎notes.txt
Lines changed: 15 additions & 1 deletion b/‎notes.txt
Lines changed: 15 additions & 1 deletion
diff --git a/‎parser/lexer.go
Lines changed: 4 additions & 4 deletions b/‎parser/lexer.go
Lines changed: 4 additions & 4 deletions
@@ -9,12 +9,26 @@ Limitations
   * string keys only in dictionaries
   * ints only 64 bit
 
+FIXME parsing 00007 works fine whereas it should be throwing an error
+
+FIXME "\tstring\n" isn't lexing properly :-(
+
+FIXME interesting crash with compiling `int("42"), sausage=11)`
+Compile error: SystemError: [interface conversion: *ast.Call is not ast.SetCtxer: missing method SetCtx]
+
+
 Todo
 ====
 
+FIXME move the whole of Vm into Frame! perpahs decode the extended args inline.
+
 Speedup
   * Make Object a fat interface so it defines all the M__method__ or at least all the common ones
-  * Make the methods be pointers in *Type more like python
+    * Embed a zero sized struct with default implementations of all the methods to avoid interface bloat
+    * except for String/Int/Bool/Tuple/Float/Bytes and possibly some others...
+  * Or Make the methods be pointers in *Type more like python
+    * Function pointers would have to be func(a Object) (Object, error) which would mean a type assertion :-(
+    * An interface is the go way of doing this
 
 
   * Getting rid of panic/defer error handling
 
@@ -641,17 +641,17 @@ isNumber:
 	var s string
 	var err error
 	if s = octalInteger.FindString(x.line); s != "" {
-		value, err = py.IntNew(py.IntType, py.Tuple{py.String(s[2:]), py.Int(8)}, nil)
+		value, err = py.IntFromString(s[2:], 8)
 		if err != nil {
 			panic(err)
 		}
 	} else if s = hexInteger.FindString(x.line); s != "" {
-		value, err = py.IntNew(py.IntType, py.Tuple{py.String(s[2:]), py.Int(16)}, nil)
+		value, err = py.IntFromString(s[2:], 16)
 		if err != nil {
 			panic(err)
 		}
 	} else if s = binaryInteger.FindString(x.line); s != "" {
-		value, err = py.IntNew(py.IntType, py.Tuple{py.String(s[2:]), py.Int(2)}, nil)
+		value, err = py.IntFromString(s[2:], 2)
 		if err != nil {
 			panic(err)
 		}
@@ -687,7 +687,7 @@ isNumber:
 				x.Error("illegal decimal with leading zero")
 				return eofError, nil
 			}
-			value, err = py.IntNew(py.IntType, py.Tuple{py.String(s), py.Int(10)}, nil)
+			value, err = py.IntFromString(s, 10)
 			if err != nil {
 				panic(err)
 			}
Original file line number	Diff line number	Diff line change
`@@ -641,17 +641,17 @@ isNumber:`
`641`	`641`	`var s string`
`642`	`642`	`var err error`
`643`	`643`	`if s = octalInteger.FindString(x.line); s != "" {`
`644`		`- value, err = py.IntNew(py.IntType, py.Tuple{py.String(s[2:]), py.Int(8)}, nil)`
	`644`	`+ value, err = py.IntFromString(s[2:], 8)`
`645`	`645`	`if err != nil {`
`646`	`646`	`panic(err)`
`647`	`647`	`}`
`648`	`648`	`} else if s = hexInteger.FindString(x.line); s != "" {`
`649`		`- value, err = py.IntNew(py.IntType, py.Tuple{py.String(s[2:]), py.Int(16)}, nil)`
	`649`	`+ value, err = py.IntFromString(s[2:], 16)`
`650`	`650`	`if err != nil {`
`651`	`651`	`panic(err)`
`652`	`652`	`}`
`653`	`653`	`} else if s = binaryInteger.FindString(x.line); s != "" {`
`654`		`- value, err = py.IntNew(py.IntType, py.Tuple{py.String(s[2:]), py.Int(2)}, nil)`
	`654`	`+ value, err = py.IntFromString(s[2:], 2)`
`655`	`655`	`if err != nil {`
`656`	`656`	`panic(err)`
`657`	`657`	`}`
`@@ -687,7 +687,7 @@ isNumber:`
`687`	`687`	`x.Error("illegal decimal with leading zero")`
`688`	`688`	`return eofError, nil`
`689`	`689`	`}`
`690`		`- value, err = py.IntNew(py.IntType, py.Tuple{py.String(s), py.Int(10)}, nil)`
	`690`	`+ value, err = py.IntFromString(s, 10)`
`691`	`691`	`if err != nil {`
`692`	`692`	`panic(err)`
`693`	`693`	`}`