resolved benign Go warnings

Drew O'Meara · Drew O'Meara · commit e867ef0f5ce9 · 2022-01-28T12:05:32.000-06:00
diff --git a/builtin/builtin.go b/builtin/builtin.go
@@ -749,9 +749,9 @@ func builtin_compile(self py.Object, args py.Tuple, kwargs py.StringDict) (py.Ob
 		return nil, py.ExceptionNewf(py.ValueError, "compile(): invalid optimize value")
 	}
 
-	if dont_inherit.(py.Int) != 0 {
+	// if dont_inherit.(py.Int) != 0 {
 		// PyEval_MergeCompilerFlags(&cf)
-	}
+	// }
 
 	// switch string(startstr.(py.String)) {
 	// case "exec":
@@ -882,9 +882,8 @@ or ... etc.
 `
 
 func isinstance(obj py.Object, classOrTuple py.Object) (py.Bool, error) {
-	switch classOrTuple.(type) {
+	switch class_tuple := classOrTuple.(type) {
 	case py.Tuple:
-		var class_tuple = classOrTuple.(py.Tuple)
 		for idx := range class_tuple {
 			res, _ := isinstance(obj, class_tuple[idx])
 			if res {
diff --git a/compile/compile.go b/compile/compile.go
@@ -1342,7 +1342,6 @@ func (c *compiler) NameOp(name string, ctx ast.ExprContext) {
 		default:
 			panic("NameOp: ctx invalid for name variable")
 		}
-		break
 	}
 	if op == 0 {
 		panic("NameOp: Op not set")
diff --git a/compile/instructions_test.go b/compile/instructions_test.go
@@ -53,7 +53,7 @@ func TestLnotab(t *testing.T) {
 		},
 	} {
 		got := test.instrs.Lnotab()
-		if bytes.Compare(test.want, got) != 0 {
+		if !bytes.Equal(test.want, got) {
 			t.Errorf("%d: want %d got %d", i, test.want, got)
 		}
 	}
diff --git a/marshal/marshal.go b/marshal/marshal.go
@@ -448,7 +448,7 @@ func ReadPyc(r io.Reader) (obj py.Object, err error) {
 	}
 	// FIXME do something with timestamp & length?
 	if header.Magic>>16 != 0x0a0d {
-		return nil, errors.New("Bad magic in .pyc file")
+		return nil, errors.New("bad magic in .pyc file")
 	}
 	// fmt.Printf("header = %v\n", header)
 	return ReadObject(r)
diff --git a/parser/stringescape.go b/parser/stringescape.go
@@ -18,7 +18,7 @@ func DecodeEscape(in *bytes.Buffer, byteMode bool) (out *bytes.Buffer, err error
 	// Early exit if no escape sequences
 	// NB in.Bytes() is cheap
 	inBytes := in.Bytes()
-	if bytes.IndexRune(inBytes, '\\') < 0 {
+	if !bytes.ContainsRune(inBytes, '\\') {
 		return in, nil
 	}
 	out = new(bytes.Buffer)
@@ -135,7 +135,6 @@ func DecodeEscape(in *bytes.Buffer, byteMode bool) (out *bytes.Buffer, err error
 			ignoreEscape = true
 		default:
 			ignoreEscape = true
-			break
 		}
 		// ignore unrecognised escape
 		if ignoreEscape {
diff --git a/py/bytes.go b/py/bytes.go
@@ -214,14 +214,14 @@ func (a Bytes) M__le__(other Object) (Object, error) {
 
 func (a Bytes) M__eq__(other Object) (Object, error) {
 	if b, ok := convertToBytes(other); ok {
-		return NewBool(bytes.Compare(a, b) == 0), nil
+		return NewBool(bytes.Equal(a, b)), nil
 	}
 	return NotImplemented, nil
 }
 
 func (a Bytes) M__ne__(other Object) (Object, error) {
 	if b, ok := convertToBytes(other); ok {
-		return NewBool(bytes.Compare(a, b) != 0), nil
+		return NewBool(!bytes.Equal(a, b)), nil
 	}
 	return NotImplemented, nil
 }
diff --git a/py/code.go b/py/code.go
@@ -97,7 +97,7 @@ const NAME_CHARS = "0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZ_abcdefghijklmnopqrstuvw
 // all_name_chars(s): true iff all chars in s are valid NAME_CHARS
 func all_name_chars(s String) bool {
 	for _, c := range s {
-		if strings.IndexRune(NAME_CHARS, c) < 0 {
+		if !strings.ContainsRune(NAME_CHARS, c) {
 			return false
 		}
 	}
diff --git a/py/int.go b/py/int.go
@@ -254,7 +254,8 @@ func (a Int) M__pos__() (Object, error) {
 
 func (a Int) M__abs__() (Object, error) {
 	if a == IntMin {
-		// FIXME upconvert
+		abig, _ := ConvertToBigInt(a)
+		return abig.M__abs__()
 	}
 	if a < 0 {
 		return -a, nil
diff --git a/py/method.go b/py/method.go
@@ -224,7 +224,7 @@ func newBoundMethod(name string, fn interface{}) (Object, error) {
 			return f(a, b, c)
 		}
 	default:
-		return nil, fmt.Errorf("Unknown bound method type for %q: %T", name, fn)
+		return nil, fmt.Errorf("unknown bound method type for %q: %T", name, fn)
 	}
 	return m, nil
 }
diff --git a/py/range.go b/py/range.go
@@ -146,7 +146,6 @@ func computeRangeLength(start, stop, step Int) Int {
 	if step > 0 {
 		lo = start
 		hi = stop
-		step = step
 	} else {
 		lo = stop
 		hi = start
diff --git a/py/string.go b/py/string.go
@@ -94,8 +94,7 @@ func StringEscape(a String, ascii bool) string {
 func fieldsN(s string, n int) []string {
 	out := []string{}
 	cur := []rune{}
-	r := []rune(s)
-	for _, c := range r {
+	for _, c := range s {
 		//until we have covered the first N elements, multiple white-spaces are 'merged'
 		if n < 0 || len(out) < n {
 			if unicode.IsSpace(c) {
@@ -139,7 +138,7 @@ func init() {
 				maxSplit = int(m)
 			}
 		}
-		valArray := []string{}
+		var valArray []string
 		if valStr, ok := value.(String); ok {
 			valArray = strings.SplitN(string(selfStr), string(valStr), maxSplit+1)
 		} else if _, ok := value.(NoneType); ok {
diff --git a/vm/eval.go b/vm/eval.go
@@ -1087,9 +1087,9 @@ func do_IMPORT_NAME(vm *Vm, namei int32) error {
 	}
 	v := vm.POP()
 	u := vm.TOP()
-	var locals py.Object = vm.frame.Locals
-	if locals == nil {
-		locals = py.None
+	var locals py.Object = py.None
+	if vm.frame.Locals != nil {
+		locals = vm.frame.Locals
 	}
 	var args py.Tuple
 	if _, ok := u.(py.Int); ok {

Original file line number	Diff line number	Diff line change
`@@ -1342,7 +1342,6 @@ func (c *compiler) NameOp(name string, ctx ast.ExprContext) {`
`1342`	`1342`	`default:`
`1343`	`1343`	`panic("NameOp: ctx invalid for name variable")`
`1344`	`1344`	`}`
`1345`		`- break`
`1346`	`1345`	`}`
`1347`	`1346`	`if op == 0 {`
`1348`	`1347`	`panic("NameOp: Op not set")`
Original file line number	Diff line number	Diff line change
`@@ -53,7 +53,7 @@ func TestLnotab(t *testing.T) {`
`53`	`53`	`},`
`54`	`54`	`} {`
`55`	`55`	`got := test.instrs.Lnotab()`
`56`		`- if bytes.Compare(test.want, got) != 0 {`
	`56`	`+ if !bytes.Equal(test.want, got) {`
`57`	`57`	`t.Errorf("%d: want %d got %d", i, test.want, got)`
`58`	`58`	`}`
`59`	`59`	`}`
Original file line number	Diff line number	Diff line change
`@@ -448,7 +448,7 @@ func ReadPyc(r io.Reader) (obj py.Object, err error) {`
`448`	`448`	`}`
`449`	`449`	`// FIXME do something with timestamp & length?`
`450`	`450`	`if header.Magic>>16 != 0x0a0d {`
`451`		`- return nil, errors.New("Bad magic in .pyc file")`
	`451`	`+ return nil, errors.New("bad magic in .pyc file")`
`452`	`452`	`}`
`453`	`453`	`// fmt.Printf("header = %v\n", header)`
`454`	`454`	`return ReadObject(r)`
Original file line number	Diff line number	Diff line change
`@@ -214,14 +214,14 @@ func (a Bytes) M__le__(other Object) (Object, error) {`
`214`	`214`
`215`	`215`	`func (a Bytes) M__eq__(other Object) (Object, error) {`
`216`	`216`	`if b, ok := convertToBytes(other); ok {`
`217`		`- return NewBool(bytes.Compare(a, b) == 0), nil`
	`217`	`+ return NewBool(bytes.Equal(a, b)), nil`
`218`	`218`	`}`
`219`	`219`	`return NotImplemented, nil`
`220`	`220`	`}`
`221`	`221`
`222`	`222`	`func (a Bytes) M__ne__(other Object) (Object, error) {`
`223`	`223`	`if b, ok := convertToBytes(other); ok {`
`224`		`- return NewBool(bytes.Compare(a, b) != 0), nil`
	`224`	`+ return NewBool(!bytes.Equal(a, b)), nil`
`225`	`225`	`}`
`226`	`226`	`return NotImplemented, nil`
`227`	`227`	`}`
Original file line number	Diff line number	Diff line change
`@@ -97,7 +97,7 @@ const NAME_CHARS = "0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZ_abcdefghijklmnopqrstuvw`
`97`	`97`	`// all_name_chars(s): true iff all chars in s are valid NAME_CHARS`
`98`	`98`	`func all_name_chars(s String) bool {`
`99`	`99`	`for _, c := range s {`
`100`		`- if strings.IndexRune(NAME_CHARS, c) < 0 {`
	`100`	`+ if !strings.ContainsRune(NAME_CHARS, c) {`
`101`	`101`	`return false`
`102`	`102`	`}`
`103`	`103`	`}`
Original file line number	Diff line number	Diff line change
`@@ -254,7 +254,8 @@ func (a Int) M__pos__() (Object, error) {`
`254`	`254`
`255`	`255`	`func (a Int) M__abs__() (Object, error) {`
`256`	`256`	`if a == IntMin {`
`257`		`- // FIXME upconvert`
	`257`	`+ abig, _ := ConvertToBigInt(a)`
	`258`	`+ return abig.M__abs__()`
`258`	`259`	`}`
`259`	`260`	`if a < 0 {`
`260`	`261`	`return -a, nil`
Original file line number	Diff line number	Diff line change
`@@ -224,7 +224,7 @@ func newBoundMethod(name string, fn interface{}) (Object, error) {`
`224`	`224`	`return f(a, b, c)`
`225`	`225`	`}`
`226`	`226`	`default:`
`227`		`- return nil, fmt.Errorf("Unknown bound method type for %q: %T", name, fn)`
	`227`	`+ return nil, fmt.Errorf("unknown bound method type for %q: %T", name, fn)`
`228`	`228`	`}`
`229`	`229`	`return m, nil`
`230`	`230`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1087,9 +1087,9 @@ func do_IMPORT_NAME(vm *Vm, namei int32) error {`
`1087`	`1087`	`}`
`1088`	`1088`	`v := vm.POP()`
`1089`	`1089`	`u := vm.TOP()`
`1090`		`- var locals py.Object = vm.frame.Locals`
`1091`		`- if locals == nil {`
`1092`		`- locals = py.None`
	`1090`	`+ var locals py.Object = py.None`
	`1091`	`+ if vm.frame.Locals != nil {`
	`1092`	`+ locals = vm.frame.Locals`
`1093`	`1093`	`}`
`1094`	`1094`	`var args py.Tuple`
`1095`	`1095`	`if _, ok := u.(py.Int); ok {`