Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid character in Access-Control-Allow-Credentials #4983

Closed
faizalmy opened this issue Jan 9, 2018 · 4 comments · Fixed by #6381
Closed

Invalid character in Access-Control-Allow-Credentials #4983

faizalmy opened this issue Jan 9, 2018 · 4 comments · Fixed by #6381
Labels
💊 bug Something isn't working
Milestone
0.12.7

Comments

@faizalmy
Copy link

faizalmy commented Jan 9, 2018 •
edited
Loading

When I set enabled ACCESS_CONTROL_ALLOW_ORIGIN = *
I got below response in the web server (Apache) log:

Response header name ''Access-Control-Allow-Credentials' ' contains invalid characters, aborting request

https://github.com/gogits/gogs/blob/9362b9fdfe41788bc600a5bc13f2df10ec2222e6/pkg/context/context.go#L268
@jbg
Copy link

jbg commented Mar 23, 2022

I'm running into this issue when trying to run v0.12.6 behind an AWS ALB. When HTTP/2 is used, all page loads fail due to the invalid header name (it contains single quotes and spaces).

The bug seems to have been fixed in Oct 2020, but the bugfix is weirdly not present in the v0.12.6 tag.

@unknwon unknwon added the 💊 bug Something isn't working label Mar 23, 2022
@unknwon
Copy link
Member

unknwon commented Mar 23, 2022

@jbg Good catch! The patch will be included in the next patch release (no ETA).

@unknwon unknwon linked a pull request Mar 23, 2022 that will close this issue
context: fix Access-Control-Allow-Credentials header typo #6381
Merged
@unknwon unknwon added this to the 0.12.7 milestone Mar 23, 2022
@unknwon
Copy link
Member

unknwon commented Mar 23, 2022

Closing this one since already fixed by #6381 on the main branch.

@unknwon unknwon closed this as completed Mar 23, 2022
@unknwon
Copy link
Member

unknwon commented May 5, 2022

The 0.12.7 has been released that includes the patch of the reported issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
💊 bug Something isn't working
Projects
None yet
Milestone
0.12.7
Development

Successfully merging a pull request may close this issue.

context: fix Access-Control-Allow-Credentials header typo wuhan005/gogs
3 participants
@jbg @faizalmy @unknwon
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy