-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Too slow docker boot on NFS mounts #6554
Comments
I'm having the same issue and would love to see this merged ! |
Hey @julienfabre, I just merged #6553, and it takes about an hour to finish automated Docker build for |
Thank you @unknwon , I'm not seeing the fix in the latest release from today though (https://github.com/gogs/gogs/releases/tag/v0.12.5), do you plan to release it separately? |
@julienfabre I haven't QA it myself just in case it breaks anything, so did not include in today's patch release. If I get the chance to do the sanity check, it could be included in the next patch release (which is currently no planned). |
QA seems good, will be included in 0.12.6. |
The 0.12.6 has been released that includes the patch of the reported issue. |
Describe the bug
I have been using the docket image as part of a new HELM v3 upgrade I made (I have no idea where to publish this as of now), and it works really good, except for a small detail.
When starting my docker image, it took a really long time to startup, and in fact the k8s cluster I used ended up terminating the container as the live check only works when the service are running.
I took a deep look inside the container, and found that there where a
chown -R $USER:$USER /data
command running. This would normally not be a problem for small and physical mounts, but my setup was a really large (20k+ files) NFS mount.I have therefor made a pull request #6553 , that change the
start.sh
to test if/data
have the ownership we expect, and then only run thechown
command when needed. There could be an argument about what happens if one of the files down the/data
tree have changed ownership, and yes ... that would be a problem. But I assume that thechown
command are here to ease migration, and not to keep file ownership in sync.I really hope this could get pulled, to allow for better NFS integration.
Gogs version and commit
master
Git version
2.30.2
Operating system
Debian Linux
Database
PostgrSQL
To Reproduce
Steps to reproduce the behavior:
/data
Can you reproduce the bug at https://try.gogs.io?
Nope, this is boot relevant
Expected behavior
Fast boot
Actual behavior
Really long startup time
The text was updated successfully, but these errors were encountered: