This repository was archived by the owner on Jun 27, 2023. It is now read-only.
Using pacakges.NeedName #418
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codyoss
approved these changes
Mar 26, 2020
|
We had talked about this internally at one time. @cvgw Brought this up, and I believe this should be safe. |
|
Thank you for your contribution 🎆 |
This was referenced Mar 11, 2021
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
packages.LoadFilesis deprecated. It is not future-proof to use it. In addition, I found all mockgen need isPackage.PkgPath, sopackages.NeedNameis sufficient.Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
Reviewer Notes