Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't Automatically Prettify JSON Data in Log #101

Open
feshbach opened this issue Nov 1, 2017 · 1 comment
Open

Don't Automatically Prettify JSON Data in Log #101

feshbach opened this issue Nov 1, 2017 · 1 comment

Comments

@feshbach
Copy link

feshbach commented Nov 1, 2017

Prettifying JSON data for the log is nice, but there should at least be a way to turn it off since it can cause the data to change.

For example, you can post content that looks like this:

{"number":2.06}

but it will be logged as:

{
    "number" : 2.0600000000000001
}

This can cause problems if you have a bug on your server but you spend all your time trying to debug the client because you have a log "proving" that's where the problem is.

@google google deleted a comment Mar 12, 2020
@thomasvl
Copy link
Member

Took a look again at this a few months ago, the catch at the moment of the removal of auth related tokens is done at the object level that happens from the parse and then reformatting. So for safety sake, there needs to be some other sorta filtering done that would provide the same protection for the logs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy