Skip to content

359913994 third pr csm with application latencies new design #1626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 465 commits into
base: main
Choose a base branch
from
Draft

359913994 third pr csm with application latencies new design #1626

wants to merge 465 commits into from
+1,574 −489

Conversation

danieljbruce
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

Description

Please provide a detailed description for the change.
As much as possible, please try to keep changes separate by purpose. For example, try not to make a one-line bug fix in a feature request, or add an irrelevant README change to a bug fix.

Impact

What's the impact of this change?

Testing

Have you added unit and integration tests if necessary?
Were any tests changed? Are any breaking changes necessary?

Additional Information

Any additional details that we should be aware of?

Checklist

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease
  • Appropriate docs were updated
  • Appropriate comments were added, particularly in complex areas or places that require background
  • No new warnings or issues will be generated from this change

Fixes #issue_number_goes_here 🦕

@danieljbruce
Remove shutdown
8edc4ab
@danieljbruce
remove async
8c9d23f
@danieljbruce
Don’t export the data twice
7b49f01
@danieljbruce
Merge branch 'main' of https://github.com/googleapis/nodejs-bigtable …
2ec12b6 
…into 359913994-exporter-PR

# Conflicts:
#	package.json
#	src/client-side-metrics/client-side-metrics-attributes.ts
#	src/client-side-metrics/metrics-handler.ts
#	test/metrics-collector/typical-method-call.txt
@danieljbruce
Increase the timeout
b4f7705
@danieljbruce
Use the PushMetricExporter interface
2a32459
@danieljbruce
Removed some interfaces that are not used anymore
e5caa9e
@danieljbruce
Update JSdoc
fc114ff
@danieljbruce
Move fake start time and fake end time
6fb5944
@danieljbruce
Remove the TODO
ca6f05e
@danieljbruce
Update documentation
4bec216
@danieljbruce
Add additional information to the error reported
bd4b0ac
@danieljbruce
Move start time and end time
c191614
@danieljbruce
Try to use timestamps in order
86be1ea
@danieljbruce
Reduce timestamp delay
3b0f081
@danieljbruce
Remove only
3ebb9ff
@danieljbruce
Inline addFakeRecentTimestamps
cf32131
@danieljbruce
Move replace timestamps into the only file it
78a20d4 
is used
@danieljbruce
Fix comment
105b58b
@danieljbruce
Rename the metric types
d4022fd
@danieljbruce
Generate documentation for the new classes
7ea28d2
@danieljbruce
Add documentation for monitored resource
7848643
@danieljbruce
Generate documentation for the other metrics
7229174
@danieljbruce
Generate documentation for the constructor
7f4e167
@danieljbruce
Get documentation for replaceTimestamps, fixtures
c86196a
@danieljbruce
Merge branch 'main' of https://github.com/googleapis/nodejs-bigtable …
41c9b2d 
…into 359913994-exporter-PR
@danieljbruce
Reduce the interval time
d76fa14
@danieljbruce
Make view list based on latencies
2f3b4e5
@danieljbruce
Add a guard for count
7a4b33e
@danieljbruce
Add a CSM test for Bigtable
eaf8879
danieljbruce added 26 commits May 28, 2025 17:32
@danieljbruce
Add chunk generation to the test
a33f9cb
@danieljbruce
Move mock server to test params
c594bbd
@danieljbruce
Include more files in tsconfig
f44e2c8
@danieljbruce
Remove imports
0d538bd
@danieljbruce
Add comments explaining different latencies
59b56e5
@danieljbruce
Add a test with handlers
1ee7acc
@danieljbruce
Remove only
d5ef2a9
@danieljbruce
No TODO
bf7bf58
@danieljbruce
Better comments
4249d10
@danieljbruce
Return file to original location
247fd5d
@danieljbruce
Better naming conventions for project
8757a65
@danieljbruce
don’t retry MSC, warning
266e65e
@danieljbruce
Change to unspecified
b394dcd
@danieljbruce
Remove unused method
910ea86
@danieljbruce
Added logic for recording application latencies
25f3beb 
Also added threading through for readRows calls
@danieljbruce
Remove only
602bc78
@danieljbruce
Merge branch '359913994-third-PR-CSM' of https://github.com/googleapi…
67fa973 
…s/nodejs-bigtable into 359913994-third-PR-CSM-with-application-latencies

# Conflicts:
#	system-test/client-side-metrics.ts
@danieljbruce
override read method
49da40c
@danieljbruce
Need to add a return statement
ac36b8b
@danieljbruce
Total application latency value
cfa6f45
@danieljbruce
Add some comments about application latency
471f7f1
@danieljbruce
Add and use a read hook
19aac8e
@danieljbruce
Correct tests and change fixture
272721f
@danieljbruce
Don’t use array for application latency
1129ad7
@danieljbruce
compiler error fixes - application latency
6fccde0
@danieljbruce
Solve fixture compile time error
c269402
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. api: bigtable Issues related to the googleapis/nodejs-bigtable API. labels Jun 25, 2025
@danieljbruce danieljbruce changed the base branch from main to 359913994-third-PR-CSM June 25, 2025 20:27
Base automatically changed from 359913994-third-PR-CSM to main June 25, 2025 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: bigtable Issues related to the googleapis/nodejs-bigtable API. size: xl Pull request size is extra large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@danieljbruce
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy