Skip to content

Commit 741a779

Browse files
author
Siddharth Gupta
committed
Add Tips to the Readme
1 parent da8c5fc commit 741a779

File tree

2 files changed

+9
-5
lines changed

2 files changed

+9
-5
lines changed

README.md

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,8 @@ The above MergeFile:
5050
* Defines a group named `Networking`. This will be the name of the resulting merged pod.
5151
* Tells the plugin to merge `AFNetworking` & `SDWebImage` into `Networking`
5252

53+
**Here's a [few important tips](https://github.com/grab/cocoapods-pod-merge#tips) to decide what pods to merge.**
54+
5355
#### 2. Update your Podfile
5456

5557
Now, update your Podfile to use the plugin, as well as the merged pods:
@@ -203,9 +205,12 @@ MergedPods/
203205

204206
This plugin is not a magic bullet that'll merge all your cocoapods into a single framework. Here's a few tips to save you from hard to debug issues after merging your pods.
205207

206-
* Start small, by merging a small number (2 to 4) of your Pods, and check everything works after the merge.
207-
* Try to make logical sense of your groups, don't just merge every single Pod your app uses into one giant pod. This can be very fragile, and can lead to hard to debug compilation / linking issues.
208-
* Refrain from merging complex or specialized pods (like pods written in C/C++). Such pods can have special build settings and compiler flags that can break the other pods that are merged with them.
208+
* **Start small**, by merging a small number (2 to 4) of your Pods, and check everything works after the merge.
209+
* Only pods which expose their **full source code** can be merged. Pods that do not expose sources, eg: `Fabric` / `Firebase` cannot be merged.
210+
* **Don't mix up** Swift and Objective-C Pods in the same group.
211+
* **Try to make logical sense of your groups**, don't just merge every single Pod your app uses into one giant pod. This can be very fragile, and can lead to hard to debug compilation / linking issues.
212+
* **Refrain from merging complex or specialized pods** (like pods written in C/C++). Such pods can have special build settings and compiler flags that can break the other pods that are merged with them.
213+
* **Make sure** you add the required [flags](https://github.com/grab/cocoapods-pod-merge#special-flags) to relevant groups in your `MergeFile`.
209214

210215

211216
## Troubleshooting

wiki/benchmarks.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818

1919
**Improvement**: **~13%** (- 27 ms)
2020

21-
According to our experience in Grab, improvements on older devices like the iPhone 5, 5c, 6 are much more drastic. As a general rule, we've seen dylib loading times decrease by **upto 50 ms** per dynamic framework on our user's slowest devices. The improvement is of-course higher on iOS versions older than iOS 13, which do not have the new shared dyld cache [dyld 3](https://developer.apple.com/videos/play/wwdc2017/413/).
21+
According to our experience in Grab, improvements on older devices like the iPhone 5, 5c, 6 are more drastic. As a general rule, we've seen dylib loading times decrease by **upto 50 ms** per dynamic framework reduced on our user's slowest devices. The improvement is of-course higher on iOS versions older than iOS 13, which do not have the new shared dyld cache [dyld 3](https://developer.apple.com/videos/play/wwdc2017/413/).
2222

2323
## Raw Data
2424

@@ -36,7 +36,6 @@ Total pre-main time: 4.7 seconds (100.0%)
3636
slowest intializers :
3737
libSystem.B.dylib : 22.25 milliseconds (0.4%)
3838

39-
4039
Total pre-main time: 3.6 seconds (100.0%)
4140
dylib loading time: 3.4 seconds (94.2%)
4241
rebase/binding time: 25.76 milliseconds (0.7%)

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy