Make more tests pass

syrusakbary · syrusakbary · commit 28387f5bcfff · 2025-06-23T18:30:16.000+02:00
diff --git a/src/graphql_server/http/async_base_view.py b/src/graphql_server/http/async_base_view.py
@@ -345,6 +345,9 @@ async def run(
         except KeyError as e:
             raise HTTPException(400, "File(s) missing in form data") from e
 
+        if request_data.variables is not None and not isinstance(request_data.variables, dict):
+            raise HTTPException(400, "Variables must be a JSON object")
+
         allowed_operation_types = operation_type_from_http(request_adapter.method)
 
         if request_adapter.method == "GET":
diff --git a/src/graphql_server/http/sync_base_view.py b/src/graphql_server/http/sync_base_view.py
@@ -200,6 +200,9 @@ def run(
         except KeyError as e:
             raise HTTPException(400, "File(s) missing in form data") from e
 
+        if request_data.variables is not None and not isinstance(request_data.variables, dict):
+            raise HTTPException(400, "Variables must be a JSON object")
+
         allowed_operation_types = operation_type_from_http(request_adapter.method)
 
         if request_adapter.method == "GET":
diff --git a/src/graphql_server/subscriptions/protocols/graphql_transport_ws/handlers.py b/src/graphql_server/subscriptions/protocols/graphql_transport_ws/handlers.py
@@ -307,7 +307,6 @@ async def run_operation(self, operation: Operation[Context, RootValue]) -> None:
             else:
                 is_first_result = True
                 async for result in result_source:
-                    print("RESULT SOURCE", result, is_first_result)
                     if (
                         is_first_result
                         and result.errors
diff --git a/src/tests/http/test_graphql_over_http_spec.py b/src/tests/http/test_graphql_over_http_spec.py
@@ -369,9 +369,6 @@ async def test_022_(http_client, parameter):
     assert "errors" not in response.json
 
 
-@pytest.mark.xfail(
-    reason="OPTIONAL - Currently results in lots of TypeErrors", raises=AssertionError
-)
 @pytest.mark.parametrize(
     "invalid",
     ["string", 0, False, ["array"]],
