-
-
Notifications
You must be signed in to change notification settings - Fork 7.8k
Add support zeroconf #39389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support zeroconf #39389
Conversation
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
It seems that this PR is targeted against an incorrect branch. Documentation updates which apply to our current stable release should target the |
📝 WalkthroughWalkthroughThe documentation for the BSBLan integration was updated to reflect support for zeroconf discovery, list available sensors and platforms, and specify a newer tested firmware version. The release link was also updated to point to the latest firmware tag. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant HomeAssistant
participant BSBLan Device
User->>HomeAssistant: Starts integration setup
HomeAssistant->>BSBLan Device: Discovers via zeroconf (mDNS)
BSBLan Device-->>HomeAssistant: Responds with device info
HomeAssistant->>User: Presents available sensors and platforms
User->>HomeAssistant: Completes configuration
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🔭 Outside diff range comments (1)
source/_integrations/bsblan.markdown (1)
55-57
:⚠️ Potential issueFix version display and punctuation.
The link text still shows “release 3.1” but points to v5.0, and the “For autodiscovery use…” sentence is missing a comma. Please apply:
-The integration is tested with the stable firmware version `5.0.16-20250525002819`. A newer firmware version may not work because the API could have changed. -For autodiscovery use the latest release. [release 3.1](https://github.com/fredlcore/BSB-LAN/releases/tag/v5.0) +The integration is tested with the stable firmware version `5.0.16-20250525002819`. A newer firmware version may not work, because the API could have changed. +For autodiscovery, use the latest release. [release v5.0](https://github.com/fredlcore/BSB-LAN/releases/tag/v5.0)🧰 Tools
🪛 LanguageTool
[uncategorized] ~56-~56: A comma might be missing here.
Context: ...because the API could have changed. For autodiscovery use the latest release. [release 3.1](h...(AI_EN_LECTOR_MISSING_PUNCTUATION_COMMA)
🧹 Nitpick comments (1)
source/_integrations/bsblan.markdown (1)
39-48
: Improve formatting of the new sensors/platforms lists.The bullet items would be clearer if you:
- Wrap sensor names in backticks (e.g.,
inside temperature
,outside temperature
).- Use the exact platform identifiers in backticks (e.g.,
climate
,water_heater
) rather than human-readable text.Example diff:
## Available sensors depending on your heating system - inside temperature - outside temperature + - `inside temperature` + - `outside temperature` ## Available platforms depending on your system - climate - water heater + - `climate` + - `water_heater`
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting
📒 Files selected for processing (1)
source/_integrations/bsblan.markdown
(2 hunks)
🧰 Additional context used
🪛 LanguageTool
source/_integrations/bsblan.markdown
[uncategorized] ~56-~56: A comma might be missing here.
Context: ...because the API could have changed. For autodiscovery use the latest release. [release 3.1](h...
(AI_EN_LECTOR_MISSING_PUNCTUATION_COMMA)
🔇 Additional comments (1)
source/_integrations/bsblan.markdown (1)
20-20
: Approve zeroconf metadata addition.Adding
ha_zeroconf: true
correctly enables mDNS discovery for this integration.
Proposed change
update documentation for zeroconfig and add some minor fixes
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.Summary by CodeRabbit