-
-
Notifications
You must be signed in to change notification settings - Fork 7.8k
Add media browsing to Russound RIO #39876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Add media browsing to Russound RIO #39876
Conversation
It seems that this PR is targeted against an incorrect branch. Documentation updates which apply to our current stable release should target the |
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
📝 WalkthroughWalkthroughThe Russound RIO integration documentation was updated with instructions on playing media presets using the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Dashboard
participant Russound RIO Integration
participant Device
User->>Dashboard: Selects preset or uses play_media action
Dashboard->>Russound RIO Integration: Sends play_media command with preset ID (and optional source ID)
Russound RIO Integration->>Device: Issues command to recall specified preset
Device-->>Russound RIO Integration: Confirms preset recall
Russound RIO Integration-->>Dashboard: Updates status
Dashboard-->>User: Displays updated media state
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (5)
source/_integrations/russound_rio.markdown (5)
71-76
: Clean up heading punctuation & trailing whitespaceMarkdown-lint flags the colon in the
### Examples:
heading (MD026
) and several trailing spaces (MD009
).
Removing the colon keeps headings succinct and avoids rule violations; trimming the end-of-line spaces prevents noisy diffs.## Playing media Russound RIO supports recalling AM/FM and Sirius XM presets using the `media_player.play_media` action. -### Examples: +### Examples
77-78
: Tighten wording & fix en-dash for numeric rangeThe sentence is a bit long and uses a hyphen (
1-36
) where an en-dash (1–36
) is preferred for ranges. A more compact version reads easier and avoids grammar-tool warnings.-Russound RIO can recall any stored presets saved on the device for a given source. The preset ID can be between 1-36. Some devices may display presets within banks of six presets total. The preset ID can be calculated by combining the current bank and preset. An example action using a preset for Bank 1, Preset 1: +Russound RIO can recall any stored presets for the current source. Preset IDs range from 1–36; some UIs group them into banks of six. You can calculate the ID by combining the bank and position. For example, Bank 1 / Preset 1:
79-97
: Surround fenced code blocks with blank lines
MD031
complains because the opening ```yaml fence is not separated from the preceding text by a blank line (same for the closing fence).
Adding a single blank line before/after each fenced block resolves this across all three examples.-An example action using a preset for Bank 2, Preset 1: -```yaml +An example action using a preset for Bank 2, Preset 1: + +```yaml action: media_player.play_media @@ media_content_id: "7" -``` +``` +Repeat for the first and third examples.
This keeps the docs consistent with the rest of the integration pages.
99-100
: Remove superfluous blank lineTwo consecutive blank lines violate
MD012
(no-multiple-blanks) and break visual flow.- - +
110-113
: Trim trailing spacesLines 112 and 113 end with stray spaces, again triggering
MD009
. Removing them is noise-free and keeps the file tidy.-The Russound RIO integration allows you to browse saved presets from your dashboard.␠ +The Russound RIO integration allows you to browse saved presets from your dashboard.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting
📒 Files selected for processing (1)
source/_integrations/russound_rio.markdown
(1 hunks)
🧰 Additional context used
🪛 LanguageTool
source/_integrations/russound_rio.markdown
[grammar] ~71-~71: Use proper spacing conventions.
Context: ...dness - Turn on volume ## Playing media Russound RIO supports recalling AM/FM an...
(QB_NEW_EN_OTHER_ERROR_IDS_000007)
[grammar] ~73-~73: Use proper spacing conventions.
Context: ...ng the media_player.play_media
action. ### Examples: Russound RIO can recall any s...
(QB_NEW_EN_OTHER_ERROR_IDS_000007)
[grammar] ~75-~75: Use proper spacing conventions.
Context: ...ayer.play_media` action. ### Examples: Russound RIO can recall any stored prese...
(QB_NEW_EN_OTHER_ERROR_IDS_000007)
[grammar] ~77-~77: There might be a mistake here.
Context: ...n source. The preset ID can be between 1-36. Some devices may display presets wit...
(QB_NEW_EN_OTHER)
[grammar] ~77-~77: Use proper spacing conventions.
Context: ...ion using a preset for Bank 1, Preset 1: yaml action: media_player.play_media target: entity_id: media_player.russound_deck data: media_content_type: "preset" media_content_id: "1"
An example action using a preset for Ban...
(QB_NEW_EN_OTHER_ERROR_IDS_000007)
[grammar] ~88-~88: Use proper spacing conventions.
Context: ...ion using a preset for Bank 2, Preset 1: yaml action: media_player.play_media target: entity_id: media_player.russound_deck data: media_content_type: "preset" media_content_id: "7"
The action will only impact the current ...
(QB_NEW_EN_OTHER_ERROR_IDS_000007)
[grammar] ~100-~100: Use proper spacing conventions.
Context: ... recall Bank 2, Preset 2 using Source 1: yaml action: media_player.play_media target: entity_id: media_player.russound_deck data: media_content_type: "preset" media_content_id: "1,8"
## Browsing media The Russound RIO integra...
(QB_NEW_EN_OTHER_ERROR_IDS_000007)
[grammar] ~110-~110: Use proper spacing conventions.
Context: ...content_id: "1,8" ``` ## Browsing media The Russound RIO integration allows you ...
(QB_NEW_EN_OTHER_ERROR_IDS_000007)
[grammar] ~112-~112: Use proper spacing conventions.
Context: ...rowse saved presets from your dashboard. ## Troubleshooting ### There is a delay on...
(QB_NEW_EN_OTHER_ERROR_IDS_000007)
🪛 markdownlint-cli2 (0.17.2)
source/_integrations/russound_rio.markdown
73-73: Trailing spaces
Expected: 0 or 2; Actual: 1
(MD009, no-trailing-spaces)
75-75: Trailing punctuation in heading
Punctuation: ':'
(MD026, no-trailing-punctuation)
99-99: Multiple consecutive blank lines
Expected: 1; Actual: 2
(MD012, no-multiple-blanks)
101-101: Fenced code blocks should be surrounded by blank lines
(MD031, blanks-around-fences)
112-112: Trailing spaces
Expected: 0 or 2; Actual: 1
(MD009, no-trailing-spaces)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @noahhusby 👍
Proposed change
Adds small section regarding media browsing for Russound RIO
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.Summary by CodeRabbit