-
-
Notifications
You must be signed in to change notification settings - Fork 7.8k
Add Fan to Switchbot cloud #39892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Fan to Switchbot cloud #39892
Conversation
It seems that this PR is targeted against an incorrect branch. Documentation updates which apply to our current stable release should target the |
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
📝 WalkthroughWalkthroughThe SwitchBot Cloud integration documentation was updated to add support for fan devices. This includes new metadata entries for fans, a list of supported fan models, and a detailed section describing the supported fan functionalities and features. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant SwitchBot Cloud Integration
participant SwitchBot Cloud API
User ->> SwitchBot Cloud Integration: Control fan (on/off, set speed/mode)
SwitchBot Cloud Integration ->> SwitchBot Cloud API: Send fan command
SwitchBot Cloud API -->> SwitchBot Cloud Integration: Acknowledge/return status
SwitchBot Cloud Integration -->> User: Update fan state/status
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🧰 Additional context used🪛 markdownlint-cli2 (0.17.2)source/_integrations/switchbot_cloud.markdown196-196: Lists should be surrounded by blank lines (MD032, blanks-around-lists) ⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
🔇 Additional comments (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting
📒 Files selected for processing (1)
source/_integrations/switchbot_cloud.markdown
(4 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
source/_integrations/switchbot_cloud.markdown
84-84: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
85-85: Lists should be surrounded by blank lines
(MD032, blanks-around-lists)
190-190: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
191-191: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Above
(MD022, blanks-around-headings)
191-191: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
193-193: Lists should be surrounded by blank lines
(MD032, blanks-around-lists)
🔇 Additional comments (2)
source/_integrations/switchbot_cloud.markdown (2)
4-10
: Alphabetical insertion looks good
Fan
is correctly added in alphabetical order withinha_category
.
22-30
: Platform list update is correct
fan
is inserted in the expected (alphabetical) position insideha_platforms
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @XiaoLing-git 👍
Proposed change
add fan entity description
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.Summary by CodeRabbit