Make host required for hddtemp #39942

edenhaus · 2025-07-09T14:16:50Z

Proposed change

SSIA

Type of change

Spelling, grammar or other readability improvements (current branch).
Adjusted missing or incorrect information in the current documentation (current branch).
Added documentation for a new integration I'm adding to Home Assistant (next branch).
- I've opened up a PR to add logos and icons in Brands repository.
Added documentation for a new feature I'm adding to Home Assistant (next branch).
Removed stale or deprecated documentation.

Additional information

Link to parent pull request in the codebase: Make host required for hddtemp core#148496
Link to parent pull request in the Brands repository:
This PR fixes or closes issue: fixes #

Checklist

This PR uses the correct branch, based on one of the following:
- I made a change to the existing documentation and used the current branch.
- I made a change that is related to an upcoming version of Home Assistant and used the next branch.
The documentation follows the Home Assistant documentation standards.

Summary by CodeRabbit

Documentation
- Updated the example configuration for the hddtemp integration to require specifying the host parameter.
New Features
- The host field in the hddtemp integration is now mandatory and must be provided by users; it no longer defaults to localhost.

netlify · 2025-07-09T14:17:07Z

✅ Deploy Preview for home-assistant-docs ready!

Name	Link
🔨 Latest commit	`17c1e52`
🔍 Latest deploy log	https://app.netlify.com/projects/home-assistant-docs/deploys/686e79d685db7100087a2681
😎 Deploy Preview	https://deploy-preview-39942--home-assistant-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copilot

Pull Request Overview

This PR makes the host setting mandatory for the HDDTemp integration by adding it to the example configuration and updating the schema to mark it as required.

Added host field to the YAML example under platform: hddtemp
Changed the host schema property from required: false (with a default) to required: true

Comments suppressed due to low confidence (1)

source/_integrations/hddtemp.markdown:53

[nitpick] Update this description to note that host is now required and has no default (for example: 'Host where hddtemp is running. This field is required; no default will be applied.').

  description: Host where `hddtemp` is running.

coderabbitai · 2025-07-09T14:19:05Z

📝 Walkthrough

Walkthrough

The hddtemp integration documentation was updated to make the host parameter in its configuration mandatory, removing the default value of localhost. The example configuration now explicitly specifies the host parameter, and the schema requires users to provide it.

Changes

File	Change Summary
source/_integrations/hddtemp.markdown	Updated example configuration to require explicit `host` parameter; changed `host` schema to required.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Configuration
    participant HDDTempIntegration

    User ->> Configuration: Provide configuration with explicit host
    Configuration ->> HDDTempIntegration: Pass required host parameter
    HDDTempIntegration ->> HDDTempIntegration: Connect to specified host

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

source/_integrations/hddtemp.markdown (1)
41-44: Prefer a placeholder over a concrete IP in the example

Hard-coding a private-network address (192.168.1.2) can mislead users into thinking they must use that exact value. Consider using a placeholder (e.g. <HOST_IP> or 127.0.0.1) or adding an inline comment to indicate that the address should be replaced with the actual host running hddtemp.
-    host: 192.168.1.2
+    # Replace with the address of the machine running hddtemp
+    host: <HOST_IP>

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 4be1d24 and 17c1e52.

📒 Files selected for processing (1)

source/_integrations/hddtemp.markdown (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

GitHub Check: Redirect rules - home-assistant-docs
GitHub Check: Header rules - home-assistant-docs
GitHub Check: Pages changed - home-assistant-docs

🔇 Additional comments (1)

source/_integrations/hddtemp.markdown (1)

53-55: Schema update looks good – verify other pages no longer mention the old default

Marking host as required: true with no default is consistent with the core change. Please do a quick sweep of the documentation to ensure there are no remaining references to the previous localhost default (e.g. release notes, migration guides, or other integration pages) to avoid contradictory guidance.

c0ffeeca7

Thank you, @edenhaus 👍

Make host required for hddtemp

17c1e52

Copilot AI review requested due to automatic review settings July 9, 2025 14:16

home-assistant bot added has-parent This PR has a parent PR in another repo next This PR goes into the next branch labels Jul 9, 2025

edenhaus mentioned this pull request Jul 9, 2025

Make host required for hddtemp home-assistant/core#148496

Draft

19 tasks

Copilot AI reviewed Jul 9, 2025

View reviewed changes

coderabbitai bot reviewed Jul 9, 2025

View reviewed changes

c0ffeeca7 approved these changes Jul 10, 2025

View reviewed changes

c0ffeeca7 added the awaits-parent Awaits the merge of an parent PR label Jul 10, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Make host required for hddtemp #39942

Make host required for hddtemp #39942

Uh oh!

edenhaus commented Jul 9, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

netlify bot commented Jul 9, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

coderabbitai bot commented Jul 9, 2025

Walkthrough

Changes

Sequence Diagram(s)

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Uh oh!

c0ffeeca7 left a comment

Uh oh!

Uh oh!

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Uh oh!

Make host required for hddtemp #39942

Are you sure you want to change the base?

Make host required for hddtemp #39942

Uh oh!

Conversation

edenhaus commented Jul 9, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed change

Type of change

Additional information

Checklist

Summary by CodeRabbit

Uh oh!

netlify bot commented Jul 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for home-assistant-docs ready!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

coderabbitai bot commented Jul 9, 2025

Walkthrough

Changes

Sequence Diagram(s)

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

c0ffeeca7 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

edenhaus commented Jul 9, 2025 •

edited by coderabbitai bot

Loading

netlify bot commented Jul 9, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)