-
-
Notifications
You must be signed in to change notification settings - Fork 7.8k
Update octoprint.markdown #39981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update octoprint.markdown #39981
Conversation
Updates Octoprint documentation to include new File Name and File Size sensors (currently in development)
It seems that this PR is targeted against an incorrect branch. Documentation updates which apply to our current stable release should target the |
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
📝 WalkthroughWalkthroughThe documentation for the OctoPrint integration was updated to list two new supported sensors: "Current File Name" and "Current File Size." These additions appear in the "Supported sensors" section, with no other changes to functionality or structure. Changes
Sequence Diagram(s)No sequence diagram is generated as the changes are limited to documentation updates. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
source/_integrations/octoprint.markdown (1)
72-73
: Re-order and enrich the new sensor entries for consistency
- List order – All the “Current …” sensors are grouped together (Printer State, File Name/Size) in the Python implementation. Dropping the new entries at the very end breaks that logical grouping.
- Units – “Current File Size” should state the unit (bytes / KiB / MiB) to avoid ambiguity for users.
Suggested patch:
- - Current Printer State - - Estimated Finish Time - - Job Completed Percentage - - Estimated Start Time - - Target Bed Temperature - - Target Tool (Nozzle) Temperature - - Current File Name - - Current File Size + - Current Printer State + - Current File Name + - Current File Size *(bytes)* + - Estimated Finish Time + - Job Completed Percentage + - Estimated Start Time + - Target Bed Temperature + - Target Tool (Nozzle) TemperatureThis restores the logical grouping and documents the unit.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting
📒 Files selected for processing (1)
source/_integrations/octoprint.markdown
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Redirect rules - home-assistant-docs
- GitHub Check: Header rules - home-assistant-docs
- GitHub Check: Pages changed - home-assistant-docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @leversonic 👍
Updates Octoprint documentation to include new File Name and File Size sensors (currently in development)
Proposed change
This change adds documentation to include new File Name and File Size sensors added by the linked PR (see Additional Information).
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.Summary by CodeRabbit